Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conventional-changelog-core: Inline deleted options types #69625

Conversation

sandersn
Copy link
Contributor

conventional-recommended-bump was recently deleted in favour of the official types, which don't include the Options type used by conventional-changelog-core. This PR inlines the RecommendedBumpOptions into conventional-changelog-core. In my opinion, this is an improvement anyway since there was a circular dependency between the two packages.

conventional-recommended-bump was recently deleted in favour of the
official types, which don't include the Options type used by
conventional-changelog-core. This PR inlines the RecommendedBumpOptions
into conventional-changelog-core. In my opinion, this is an improvement
anyway since there was a circular dependency between the two packages.
@typescript-bot
Copy link
Contributor

typescript-bot commented May 16, 2024

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69625,
  "author": "sandersn",
  "headCommitOid": "9b242b132d97eab3234cbe23fd89035e1e140ee3",
  "mergeBaseOid": "cb74c940100800002511f412841ecd6cdc4c4e65",
  "lastPushDate": "2024-05-16T22:38:41.000Z",
  "lastActivityDate": "2024-05-16T22:38:41.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "conventional-changelog-core",
      "kind": "edit",
      "files": [
        {
          "path": "types/conventional-changelog-core/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2116316913,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label May 16, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 16, 2024
@typescript-bot
Copy link
Contributor

🔔 @JasonHK — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 16, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board May 17, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 17, 2024
@sandersn
Copy link
Contributor Author

I'm going to merge this to make the nightly test run pass, but please do add any comments you have.

@sandersn sandersn merged commit 6c3dfd4 into DefinitelyTyped:master May 17, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board May 17, 2024
@sandersn sandersn deleted the inline-options-conventional-changelog-core branch May 17, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants