Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gamedig] Fix attw errors for 5.0 stable #69624

Merged
merged 1 commit into from
May 16, 2024

Conversation

andrewbranch
Copy link
Member

Please fill in this template.

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented May 16, 2024

@andrewbranch Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69624,
  "author": "andrewbranch",
  "headCommitOid": "26983d20e697df57628d0028a161de6f75f7d7da",
  "mergeBaseOid": "cb74c940100800002511f412841ecd6cdc4c4e65",
  "lastPushDate": "2024-05-16T22:16:36.000Z",
  "lastActivityDate": "2024-05-16T23:23:35.000Z",
  "mergeOfferDate": "2024-05-16T22:30:52.000Z",
  "mergeRequestDate": "2024-05-16T23:23:35.000Z",
  "mergeRequestUser": "andrewbranch",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "gamedig",
      "kind": "edit",
      "files": [
        {
          "path": "types/gamedig/gamedig-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/gamedig/index.d.cts",
          "kind": "definition"
        },
        {
          "path": "types/gamedig/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/gamedig/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "ivansieder",
        "p4sca1",
        "MaximumWoahverdrive"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2024-05-16T22:30:16.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2116296730,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 16, 2024
@typescript-bot
Copy link
Contributor

🔔 @ivansieder @P4sca1 @MaximumWoahverdrive — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link

Formatting

The following files are not formatted:

  1. types/gamedig/package.json

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 26983d2

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels May 16, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board May 16, 2024
@typescript-bot
Copy link
Contributor

@andrewbranch: Everything looks good here. I am ready to merge this PR (at 26983d2) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ivansieder, @P4sca1, @MaximumWoahverdrive: you can do this too.)

@andrewbranch
Copy link
Member Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board May 16, 2024
@typescript-bot typescript-bot merged commit 51c7dbd into DefinitelyTyped:master May 16, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants