phoenix_live_view: Add longPollFallbackMs to SocketOptions

[rhcarvalho]

The phoenix_live_view.LiveSocket passes its options to phoenix.Socket, and longpoll fallback was added 4 months ago in Phoenix 1.7.11.

---

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: linked inline above.
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json. please see phoenix_live_view: Add longPollFallbackMs to SocketOptions #69617 (comment)

[typescript-bot]

@rhcarvalho Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• phoenix_live_view — on npm, on unpkg
  • owner-approval: @pzingg

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69617,
  "author": "rhcarvalho",
  "headCommitOid": "5bd1ae34e2e1436943163a9d3163546fc5f1cb8d",
  "mergeBaseOid": "bfdcd1c2bad2ed372ebf698103824f4171e5e972",
  "lastPushDate": "2024-05-15T10:03:41.000Z",
  "lastActivityDate": "2024-05-16T15:50:18.000Z",
  "mergeOfferDate": "2024-05-16T13:59:05.000Z",
  "mergeRequestDate": "2024-05-16T15:50:18.000Z",
  "mergeRequestUser": "rhcarvalho",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "phoenix_live_view",
      "kind": "edit",
      "files": [
        {
          "path": "types/phoenix_live_view/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "pzingg"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "sandersn",
      "date": "2024-05-16T13:58:27.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "pzingg",
      "date": "2024-05-15T14:46:20.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2112092558,
  "ciResult": "pass"
}

[typescript-bot]

Hey @rhcarvalho,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

[typescript-bot]

🔔 @pzingg — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@rhcarvalho The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[rhcarvalho]

• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

Since the type change is in a related package https://www.npmjs.com/package/phoenix, and not https://www.npmjs.com/package/phoenix_live_view, I'm not sure what version to bump to.

[pzingg]

Thanks for catching this! Approved.

[typescript-bot]

@rhcarvalho: Everything looks good here. I am ready to merge this PR (at 5bd1ae3) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@pzingg: you can do this too.)

[rhcarvalho]

Thank you for the reviews. Ready to merge!

[rhcarvalho]

Ready to merge