[jsrsasign] add missing null type in X509CRL.getRevCertArray()

[bindon]

The null type is missing in getRevCertArray() within the X509CRL.d.ts file.

/**
 * get array for revokedCertificates field<br/>
 * name getRevCertArray
 * memberOf X509CRL#
 *
 * @return Array array of revokedCertificate parameter or null
 * @see X509CRL#getRevCert
 *
 * @description
 * This method returns parsed revokedCertificates field value as
 * array of revokedCertificate parameter.
 * If the field doesn't exists, it returns null.
 *
 * @example
 * crl = new X509CRL("-----BEGIN X509 CRL...");
 * crl.getRevCertArray() &rarr;
 * [{sn:"123a", date:"208025235959Z", ext: [{extname:"cRLReason",code:3}]},
 *  {sn:"123b", date:"208026235959Z", ext: [{extname:"cRLReason",code:0}]}]
 */
getRevCertArray(): RevokedCertificate[]; // this! + "| null"

The null type is also missing as described in the comments below.

• @ return Array array of revokedCertificate parameter or null
• If the field doesn't exists, it returns null.

The part implemented in JavaScript is as follows:

this.getRevCertArray = function() {
  if (this.posRevCert == null) return null; // this line!
    var a = [];
    var idx = _getIdxbyList(this.hex, 0, [0, this.posRevCert]);
    var aIdx = _getChildIdx(this.hex, idx);
    for (var i = 0; i < aIdx.length; i++) {
    var hRevCert = _getTLV(this.hex, aIdx[i]);
    a.push(this.getRevCert(hRevCert));
  }
  return a;
};

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• [Run pnpm test <package to test>]
• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/kjur/jsrsasign/blob/master/src/x509crl.js#L272

[typescript-bot]

@bindon Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• jsrsasign — on npm, on unpkg
  • owner-approval: @ffflorian

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69462,
  "author": "bindon",
  "headCommitOid": "0d9ff3e650f03b8f6ea9da2e22c357cb70e46eb3",
  "mergeBaseOid": "d693ab3ced5aa2b8d86838f721006b16414bb21e",
  "lastPushDate": "2024-04-29T04:45:59.000Z",
  "lastActivityDate": "2024-05-03T04:27:01.000Z",
  "mergeOfferDate": "2024-05-02T19:20:36.000Z",
  "mergeRequestDate": "2024-05-03T04:27:01.000Z",
  "mergeRequestUser": "bindon",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "jsrsasign",
      "kind": "edit",
      "files": [
        {
          "path": "types/jsrsasign/jsrsasign-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/jsrsasign/modules/X509CRL.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "ffflorian"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "ffflorian",
      "date": "2024-05-02T19:19:56.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2081882417,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @ffflorian — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@bindon: Everything looks good here. I am ready to merge this PR (at 0d9ff3e) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@ffflorian: you can do this too.)

[bindon]

Ready to merge