Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more mentions of header in README #69443

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

jakebailey
Copy link
Member

These were missed during the monorepo refactor.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 25, 2024

@jakebailey Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

0 packages in this PR (and infra files)

Code Reviews

There aren't any other owners of this package, so a DT maintainer will review it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • 🕐 Continuous integration tests are still running
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (README.md)

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69443,
  "author": "jakebailey",
  "headCommitOid": "bccd007ad66abf64f1c8fbf69ecd9d9ce9b22b15",
  "mergeBaseOid": "336514bf08407af44d188b44a55194d029a888cb",
  "lastPushDate": "2024-04-25T21:48:48.000Z",
  "lastActivityDate": "2024-04-25T21:51:02.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "README.md",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical",
      "isSafeInfrastructureEdit": false
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "bcbailey",
      "date": "2024-04-25T21:51:02.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2024-04-25T21:49:31.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2078231873,
  "ciResult": "unknown"
}

@typescript-bot
Copy link
Contributor

🔔 @jakebailey — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Apr 25, 2024
@bcbailey
Copy link
Contributor

Thanks for the help Jake!

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Apr 25, 2024
@jakebailey jakebailey merged commit 07d0f83 into DefinitelyTyped:master Apr 25, 2024
5 checks passed
@jakebailey jakebailey deleted the fix-minimum-readme branch April 25, 2024 21:51
@typescript-bot typescript-bot removed this from Waiting for Code Reviews in New Pull Request Status Board Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Maintainer Approved Other Approved This PR was reviewed and signed-off by a community member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants