[@types/node]: update directories for node v22 #69438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielcuque Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69438,
"author": "danielcuque",
"headCommitOid": "6e503f54c798f398c8f17499d7dfd4930185adc0",
"mergeBaseOid": "67ed83d31b2c8c0381b964b0897fc2457b874d11",
"lastPushDate": "2024-04-25T01:25:03.000Z",
"lastActivityDate": "2024-05-01T18:33:27.000Z",
"hasMergeConflict": true,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": true,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/node/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/async_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/child_process.d.ts",
"kind": "definition"
},
{
"path": "types/node/cluster.d.ts",
"kind": "definition"
},
{
"path": "types/node/console.d.ts",
"kind": "definition"
},
{
"path": "types/node/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/diagnostics_channel.d.ts",
"kind": "definition"
},
{
"path": "types/node/dns.d.ts",
"kind": "definition"
},
{
"path": "types/node/domain.d.ts",
"kind": "definition"
},
{
"path": "types/node/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/http2.d.ts",
"kind": "definition"
},
{
"path": "types/node/https.d.ts",
"kind": "definition"
},
{
"path": "types/node/inspector.d.ts",
"kind": "definition"
},
{
"path": "types/node/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/os.d.ts",
"kind": "definition"
},
{
"path": "types/node/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/path.d.ts",
"kind": "definition"
},
{
"path": "types/node/perf_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/punycode.d.ts",
"kind": "definition"
},
{
"path": "types/node/querystring.d.ts",
"kind": "definition"
},
{
"path": "types/node/readline.d.ts",
"kind": "definition"
},
{
"path": "types/node/repl.d.ts",
"kind": "definition"
},
{
"path": "types/node/sea.d.ts",
"kind": "definition"
},
{
"path": "types/node/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/string_decoder.d.ts",
"kind": "definition"
},
{
"path": "types/node/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/timers.d.ts",
"kind": "definition"
},
{
"path": "types/node/tls.d.ts",
"kind": "definition"
},
{
"path": "types/node/trace_events.d.ts",
"kind": "definition"
},
{
"path": "types/node/tty.d.ts",
"kind": "definition"
},
{
"path": "types/node/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/.eslintrc.json",
"kind": "package-meta",
"suspect": "edited"
},
{
"path": "types/node/v20/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/node/v20/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/assert/strict.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/async_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/child_process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/cluster.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/console.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/constants.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/diagnostics_channel.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/dns.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/dns/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/dom-events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/domain.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/fs/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/globals.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/globals.global.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/http2.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/https.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/inspector.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/node-tests-dom.ts",
"kind": "test"
},
{
"path": "types/node/v20/node-tests-non-dom.ts",
"kind": "test"
},
{
"path": "types/node/v20/node-tests.ts",
"kind": "test"
},
{
"path": "types/node/v20/os.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/node/v20/path.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/perf_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/punycode.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/querystring.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/readline.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/readline/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/repl.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/sea.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/stream/consumers.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/stream/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/stream/web.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/string_decoder.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/test.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/test/assert.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/async_hooks.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/buffer.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/child_process.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/cluster.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/console.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/constants.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/crypto.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/dgram.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/diagnostics_channel.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/dns.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/events-dom.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/events-non-dom.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/events.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/events_generic.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/fs.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/globals-dom.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/globals-non-dom.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/globals.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/http.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/http2.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/https.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/inspector.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/module.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/net.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/os.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/path.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/perf_hooks-dom.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/perf_hooks-non-dom.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/perf_hooks.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/process.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/querystring.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/readline.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/repl.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/sea.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/stream.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/string_decoder.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/test.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/timers.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/timers_promises.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/tls.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/trace_events.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/tty.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/url.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/util.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/util_types.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/v8.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/vm.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/wasi.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/worker_threads.ts",
"kind": "test"
},
{
"path": "types/node/v20/test/zlib.ts",
"kind": "test"
},
{
"path": "types/node/v20/timers.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/timers/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/tls.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/trace_events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/tsconfig.dom.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`)"
},
{
"path": "types/node/v20/tsconfig.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`)"
},
{
"path": "types/node/v20/tsconfig.non-dom.json",
"kind": "package-meta",
"suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.target`)"
},
{
"path": "types/node/v20/tty.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/v8.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/vm.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/wasi.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/worker_threads.d.ts",
"kind": "definition"
},
{
"path": "types/node/v20/zlib.d.ts",
"kind": "definition"
},
{
"path": "types/node/v8.d.ts",
"kind": "definition"
},
{
"path": "types/node/vm.d.ts",
"kind": "definition"
},
{
"path": "types/node/wasi.d.ts",
"kind": "definition"
},
{
"path": "types/node/worker_threads.d.ts",
"kind": "definition"
},
{
"path": "types/node/zlib.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"galkin",
"parambirs",
"eps1lon",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13",
"mcollina",
"Semigradsky"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "Semigradsky",
"date": "2024-04-25T07:21:20.000Z",
"abbrOid": "e700ec0"
}
],
"mainBotCommentID": 2076139533,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/6e503f54c798f398c8f17499d7dfd4930185adc0/checks?check_suite_id=23144178013"
} |
typescript-bot
added
Critical package
Check Config
|
🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in New Pull Request Status Board
|
@danielcuque The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
typescript-bot
added
Edits Infrastructure
and removed
The CI failed
typescript-bot
moved this from Needs Author Action
to Waiting for Code Reviews
in New Pull Request Status Board
typescript-bot
added
The CI failed
|
@danielcuque The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in New Pull Request Status Board
typescript-bot
added
Edits multiple packages
and removed
The CI failed
typescript-bot
moved this from Needs Author Action
to Waiting for Code Reviews
in New Pull Request Status Board
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in New Pull Request Status Board
|
@danielcuque The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Semigradsky
reviewed
Apr 25, 2024
|
Would be nice to merge #69212 before this... |
This reverts commit e700ec0.
typescript-bot
removed
Edits multiple packages
The CI failed
typescript-bot
moved this from Needs Author Action
to Waiting for Code Reviews
in New Pull Request Status Board
typescript-bot
moved this from Waiting for Code Reviews
to Needs Author Action
in New Pull Request Status Board
|
@danielcuque The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
|
#69212 is now merged, work on this PR can be resumed. Try closing and reopening the PR to fix the CI error. |
typescript-bot
added
the
Has Merge Conflict
|
@danielcuque Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day! |
|
@danielcuque any plans to revive this one? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
pnpm test <package to test>.Motivation
Node 22