New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[itowns] Release 2.43.0 #69433
base: master
Are you sure you want to change the base?
[itowns] Release 2.43.0 #69433
Conversation
@Desplandis Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 22 days. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69433,
"author": "Desplandis",
"headCommitOid": "f41678ee520a5b4b7522f267fda4a6c1e5f745cc",
"mergeBaseOid": "b8d1466d9111780dca384f9d79ac7f8c696efc01",
"lastPushDate": "2024-04-24T15:26:42.000Z",
"lastActivityDate": "2024-04-24T15:26:42.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "itowns",
"kind": "edit",
"files": [
{
"path": "types/itowns/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/itowns/src/Core/View.d.ts",
"kind": "definition"
},
{
"path": "types/itowns/src/Layer/EntwinePointTileLayer.d.ts",
"kind": "definition"
},
{
"path": "types/itowns/src/Layer/GeoidLayer.d.ts",
"kind": "definition"
},
{
"path": "types/itowns/src/Layer/LabelLayer.d.ts",
"kind": "definition"
},
{
"path": "types/itowns/src/Layer/PointCloudLayer.d.ts",
"kind": "definition"
},
{
"path": "types/itowns/src/Layer/PotreeLayer.d.ts",
"kind": "definition"
},
{
"path": "types/itowns/src/Layer/TiledGeometryLayer.d.ts",
"kind": "definition"
},
{
"path": "types/itowns/src/Main.d.ts",
"kind": "definition"
},
{
"path": "types/itowns/src/Renderer/Camera.d.ts",
"kind": "definition"
},
{
"path": "types/itowns/src/Renderer/PointsMaterial.d.ts",
"kind": "definition"
},
{
"path": "types/itowns/src/Source/EntwinePointTileSource.d.ts",
"kind": "definition"
},
{
"path": "types/itowns/test/3DTiles25D.ts",
"kind": "test"
}
],
"owners": [
"desplandis",
"mgermerie"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 2075256491,
"ciResult": "fail",
"ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/f41678ee520a5b4b7522f267fda4a6c1e5f745cc/checks?check_suite_id=23107966534"
} |
🔔 @mgermerie — please review this PR in the next few days. Be sure to explicitly select |
@Desplandis The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review. |
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If changing an existing definition:
package.json
.