[trianglify]: fix trianglify types

[fdaciuk]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test trianglify.
• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/qrohlf/trianglify/blob/master/src/trianglify.js#L19-L33
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

[typescript-bot]

@fdaciuk Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• trianglify — on npm, on unpkg
  • 1 added owner: ✎@fdaciuk
  • Config files to check:
    • trianglify/tsconfig.json: not the expected form and not moving towards it (check: compilerOptions.exactOptionalPropertyTypes)

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ A DT maintainer needs to approve changes which affect module config files

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69426,
  "author": "fdaciuk",
  "headCommitOid": "ded6548afc5c5f7e361327abef094bc773463cd0",
  "mergeBaseOid": "9ff6856db12ba15015b91b2466171b7f27ab3677",
  "lastPushDate": "2024-04-23T23:31:50.000Z",
  "lastActivityDate": "2024-05-15T21:51:03.000Z",
  "mergeOfferDate": "2024-05-15T21:10:14.000Z",
  "mergeRequestDate": "2024-05-15T21:51:03.000Z",
  "mergeRequestUser": "fdaciuk",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "trianglify",
      "kind": "edit",
      "files": [
        {
          "path": "types/trianglify/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/trianglify/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/trianglify/trianglify-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/trianglify/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.exactOptionalPropertyTypes`)"
        }
      ],
      "owners": [
        "unindented"
      ],
      "addedOwners": [
        "fdaciuk"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2024-05-15T21:09:37.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2073654179,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @unindented — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@fdaciuk The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@fdaciuk The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

Re-ping @unindented:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

[peterblazejewicz]

Let's wait a little more, the changes are braking, introducing new version and new module exports, etc.
ping @unindented

[fdaciuk]

@peterblazejewicz the types were from an older version of trianglify. The update is to use the current version of the lib (4.1.1), as you can see here

[typescript-bot]

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @fdaciuk.

(Ping @unindented.)

[peterblazejewicz]

I think this is inconsistent, defaults like width/height should not have the defaults, so no undefined as supported type, that looks OK. But here (and other places) fill, won't have default null, if someone passes undefined:
https://github.com/qrohlf/trianglify/blob/master/src/trianglify.js#L48

[fdaciuk]

You're right, my bad 🙈. I'll test every property to make sure they are consistent and I'll update this PR =)

Thanks for your review ❤️

[fdaciuk]

Done @peterblazejewicz =)

[typescript-bot]

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

[peterblazejewicz]

LGTM
@fdaciuk thanks!

[typescript-bot]

@fdaciuk: Everything looks good here. I am ready to merge this PR (at ded6548) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@unindented: you can do this too.)

[fdaciuk]

Ready to merge