[forge-viewer] update for version 7.89

[yiskang]

• Move PropDbLoader to Private namespace and change its type from interface to class.
• Add some missing fields and functions to PropDbLoader and Model.
• Correct type declarations for LoadModelOptions and options in viewer#loadDocumentNode.
• Add isMasterView() to BubbleNode.
• Update test codes.
• Updated version number.

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run pnpm test <package to test>.

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
• Create it with dts-gen --dt, not by basing it on an existing project.
• Represents shape of module/library correctly
• tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:
  - https://aps.autodesk.com/en/docs/viewer/v7/reference/Private/PropDbLoader/
  - https://aps.autodesk.com/en/docs/viewer/v7/reference/Viewing/Model/
  - https://aps.autodesk.com/en/docs/viewer/v7/reference/Viewing/Viewer3D/#loadmodel-url-options-onsuccesscallback-onerrorcallback
  - https://aps.autodesk.com/en/docs/viewer/v7/reference/Viewing/BubbleNode/
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

• If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
• Delete the package's directory.
• Add it to notNeededPackages.json.

[typescript-bot]

@yiskang Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• forge-viewer — on npm, on unpkg
  • 2 added owners: @autodesk-platform-services, ✎@yiskang
  • Config files to check:
    • forge-viewer/tsconfig.json: not the expected form and not moving towards it (check: compilerOptions.lib.1)

@yiskang: I see that you have added yourself as an owner, are you sure you want to become an owner?

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ A DT maintainer needs to approve changes which affect module config files

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 69419,
  "author": "yiskang",
  "headCommitOid": "14f9972baf7f67bef92a0e562b30edd18de62d52",
  "mergeBaseOid": "9ec204164d296bac9574f8113417236cae2a5d62",
  "lastPushDate": "2024-04-23T14:20:30.000Z",
  "lastActivityDate": "2024-05-03T02:38:53.000Z",
  "mergeOfferDate": "2024-05-02T14:05:41.000Z",
  "mergeRequestDate": "2024-05-03T02:38:53.000Z",
  "mergeRequestUser": "yiskang",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "forge-viewer",
      "kind": "edit",
      "files": [
        {
          "path": "types/forge-viewer/forge-viewer-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/forge-viewer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/forge-viewer/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/forge-viewer/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) and not moving towards it (check: `compilerOptions.lib.1`)"
        }
      ],
      "owners": [
        "Autodesk-Forge",
        "alansmithnbs",
        "liskaj",
        "petrbroz",
        "cyrillef"
      ],
      "addedOwners": [
        "autodesk-platform-services",
        "yiskang"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2024-05-02T14:05:02.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2072446860,
  "ciResult": "pass"
}

[typescript-bot]

🔔 @Autodesk-Forge @alansmithnbs @liskaj @petrbroz @cyrillef — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

@yiskang The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

[typescript-bot]

@yiskang: Everything looks good here. I am ready to merge this PR (at 14f9972) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Autodesk-Forge, @alansmithnbs, @liskaj, @petrbroz, @cyrillef: you can do this too.)

[yiskang]

Ready to merge