New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[types/binary-parser] Fix 4 typos in 3 files #69414
[types/binary-parser] Fix 4 typos in 3 files #69414
Conversation
Co-authored-by: RoAGmer <no-reply@github.com> Signed-off-by: RoboSchmied <github@roboschmie.de>
@RoboSchmied Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 2 packages in this PRCode ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69414,
"author": "RoboSchmied",
"headCommitOid": "9ef221e4c006b73b318016b08b52b5b4875c89b7",
"mergeBaseOid": "6918081f66a51df9eab940d9b690d627467c4401",
"lastPushDate": "2024-04-22T18:45:11.000Z",
"lastActivityDate": "2024-05-01T22:07:42.000Z",
"mergeOfferDate": "2024-05-01T21:59:59.000Z",
"mergeRequestDate": "2024-05-01T22:07:42.000Z",
"mergeRequestUser": "RoboSchmied",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "binary-parser",
"kind": "edit",
"files": [
{
"path": "types/binary-parser/binary-parser-tests.ts",
"kind": "test"
},
{
"path": "types/binary-parser/index.d.ts",
"kind": "definition"
}
],
"owners": [
"riggs",
"dolanmiu",
"yuhr",
"caguiclajmg"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "bytebuffer",
"kind": "edit",
"files": [
{
"path": "types/bytebuffer/index.d.ts",
"kind": "definition"
}
],
"owners": [],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "rbuckton",
"date": "2024-05-01T21:59:08.000Z",
"isMaintainer": true
},
{
"type": "approved",
"reviewer": "yuhr",
"date": "2024-04-22T18:48:06.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 2070618228,
"ciResult": "pass"
} |
🔔 @riggs @dolanmiu @yuhr @caguiclajmg — please review this PR in the next few days. Be sure to explicitly select |
Ready to merge |
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
package.json
.If removing a declaration:
notNeededPackages.json
.