-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[insane]: Add typing for insane #69252
Conversation
@ecancino Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69252,
"author": "ecancino",
"headCommitOid": "18209598ad78fea4bfd110e0a5ad1d06b838a420",
"mergeBaseOid": "36b11dc0aef02802bcfb4c84a71443101d29dd1f",
"lastPushDate": "2024-04-02T16:55:11.000Z",
"lastActivityDate": "2024-04-04T17:05:24.000Z",
"mergeOfferDate": "2024-04-04T15:56:11.000Z",
"mergeRequestDate": "2024-04-04T17:05:24.000Z",
"mergeRequestUser": "ecancino",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "insane",
"kind": "add",
"files": [
{
"path": "types/insane/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/insane/index.d.ts",
"kind": "definition"
},
{
"path": "types/insane/insane-tests.ts",
"kind": "test"
},
{
"path": "types/insane/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/insane/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"ecancino",
"bevacqua"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "RyanCavanaugh",
"date": "2024-04-04T15:55:29.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2032574962,
"ciResult": "pass"
} |
🔔 @ecancino — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
@ecancino One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
People who would have been pingedgyohk sonic3d rroylance singuerinc McBen alejo90 atd-schubert mcauer ronikar life777 henrythasler captain-igloo someonewithpc Microsoft jkomyno alvis r3nya btoueg smac89 touffy DeividasBakanas eyqs Hannes-Magnusson-CK hoo29 kjin ajafff islishude mwiktorczyk mohsen1 galkin parambirs eps1lon ThomasdenH WilcoBakker wwwy3y3 samuela kuehlein bhongy chyzwar trivikr yoursunny qwelias ExE-Boss peterblazejewicz addaleax victorperin ZYSzys NodeJS LinusU wafuwafu13 mcollina Semigradsky quinnlangille merufm lance mastermatt tjenkinson koss-lebedev mcmar urossmolnik devanshj |
@ecancino One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
@RyanCavanaugh Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
Ready to merge |
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
package.json
.If removing a declaration:
notNeededPackages.json
.