Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/cehub #69205

Closed
wants to merge 51 commits into from
Closed

@types/cehub #69205

wants to merge 51 commits into from

Conversation

cehub-app
Copy link

@cehub-app cehub-app commented Mar 29, 2024

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

If removing a declaration:

  • If a package was never on Definitely Typed, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 29, 2024

@cehub-app Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • 🕐 Continuous integration tests are still running
  • 🕐 Only a DT maintainer can approve changes when there are new packages added

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69205,
  "author": "cehub-app",
  "headCommitOid": "89280c89ca8eda5fbf6d3212ea5166cbab06a1e9",
  "mergeBaseOid": "8de1d4d9a6f1f25a9e5a142046a4740408f93772",
  "lastPushDate": "2024-03-29T16:33:16.000Z",
  "lastActivityDate": "2024-03-30T15:09:57.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "cehub",
      "kind": "add",
      "files": [
        {
          "path": "types/cehub/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/cehub/LICENSE",
          "kind": "package-meta",
          "suspect": "edited"
        },
        {
          "path": "types/cehub/README.md",
          "kind": "markdown"
        },
        {
          "path": "types/cehub/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/cehub/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/cehub/tsconfig.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "cehub-app"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "MysteryBlokHed",
      "date": "2024-03-30T15:09:57.000Z",
      "abbrOid": "bf21bd6"
    }
  ],
  "mainBotCommentID": 2027461806,
  "ciResult": "unknown"
}

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Untested Change This PR does not touch tests labels Mar 29, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Mar 29, 2024
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 29, 2024

🔔 @cehub-app — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Mar 29, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Mar 29, 2024
@typescript-bot
Copy link
Contributor

@cehub-app The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Mar 29, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Mar 29, 2024
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Mar 29, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Mar 29, 2024
@typescript-bot
Copy link
Contributor

@cehub-app The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added Check Config Changes a module config files and removed The CI failed When GH Actions fails labels Mar 29, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Mar 29, 2024
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Mar 29, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Mar 29, 2024
@typescript-bot
Copy link
Contributor

@cehub-app The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Mar 29, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Mar 29, 2024
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Mar 29, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Mar 29, 2024
@typescript-bot
Copy link
Contributor

@cehub-app The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Mar 30, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Mar 30, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Mar 30, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in New Pull Request Status Board Mar 30, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Mar 30, 2024
Copy link
Contributor

@MysteryBlokHed MysteryBlokHed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this section of the README for proper file structure: https://github.com/DefinitelyTyped/DefinitelyTyped/?tab=readme-ov-file#create-a-new-package

The LICENSE and README.md files here will be ignored, and a file should be added to test the typings

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Code Reviews in New Pull Request Status Board Mar 31, 2024
updata new
@cehub-app cehub-app marked this pull request as draft March 31, 2024 11:11
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Mar 31, 2024
@cehub-app cehub-app marked this pull request as ready for review March 31, 2024 11:12
@cehub-app cehub-app marked this pull request as draft March 31, 2024 11:12
Copy link
Contributor

@MysteryBlokHed MysteryBlokHed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(See comments from last review)

@cehub-app cehub-app closed this Apr 1, 2024
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Check Config Changes a module config files New Definition This PR creates a new definition package. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants