Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[office-js][office-js-preview] (unified manifest) Remove preview string #68907

Conversation

samantharamon
Copy link
Contributor

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: None.
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Mar 5, 2024
Copy link
Collaborator

@Rick-Kirkham Rick-Kirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just one small fix.

types/office-js-preview/index.d.ts Outdated Show resolved Hide resolved
@samantharamon samantharamon force-pushed the office-js-remove-preview-string branch from 5e137e6 to b5de367 Compare May 9, 2024 21:38
@samantharamon samantharamon marked this pull request as ready for review May 9, 2024 22:06
@typescript-bot
Copy link
Contributor

typescript-bot commented May 9, 2024

@samantharamon Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 64 days — it is still unreviewed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 68907,
  "author": "samantharamon",
  "headCommitOid": "126a8dbbafdcb3b3c58e25de0089dfddba20001b",
  "mergeBaseOid": "5b5ec4e409bcd8d422efc505db5b0223c0c5af56",
  "lastPushDate": "2024-03-05T22:58:49.000Z",
  "lastActivityDate": "2024-05-09T22:06:45.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "office-js-preview",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js-preview/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "office-js",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "Rick-Kirkham",
      "date": "2024-03-05T23:22:20.000Z",
      "abbrOid": "8b440b8"
    }
  ],
  "mainBotCommentID": 2103489862,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels May 9, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Action in New Pull Request Status Board May 9, 2024
@typescript-bot
Copy link
Contributor

🔔 @OfficeDev @Rick-Kirkham @AlexJerabek @ElizabethSamuel-MSFT @alison-mk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @samantharamon.

(Ping @OfficeDev, @Rick-Kirkham, @AlexJerabek, @ElizabethSamuel-MSFT, @alison-mk.)

@typescript-bot
Copy link
Contributor

@Rick-Kirkham Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@ElizabethSamuel-MSFT ElizabethSamuel-MSFT merged commit 1875397 into DefinitelyTyped:master May 9, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Needs Maintainer Action in New Pull Request Status Board May 9, 2024
@samantharamon samantharamon deleted the office-js-remove-preview-string branch May 9, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Edits multiple packages Popular package This PR affects a popular package (as counted by NPM download counts). Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants