Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[office-js][office-js-preview] (Outlook) Document additional mail item properties #67902

Conversation

samantharamon
Copy link
Contributor

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: None.
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 24, 2024

@samantharamon Thank you for submitting this PR!

This is a live comment which I will keep updated.

2 packages in this PR

Code Reviews

This PR can be merged once it's reviewed.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Type definition owners or DT maintainers needs to approve changes which affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 115 days — it is still unreviewed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 67902,
  "author": "samantharamon",
  "headCommitOid": "aa878944f016148b92f868de1d3ed384ebb14523",
  "mergeBaseOid": "9b0f901d1017d4503b49629e672f8560dd88956e",
  "lastPushDate": "2023-12-16T02:51:52.000Z",
  "lastActivityDate": "2024-04-08T19:34:50.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "office-js-preview",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js-preview/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "office-js",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "ndeleuze",
      "date": "2024-04-05T16:47:38.000Z",
      "abbrOid": "d37c895"
    },
    {
      "type": "stale",
      "reviewer": "Rick-Kirkham",
      "date": "2024-02-06T03:32:14.000Z",
      "abbrOid": "a3c33d0"
    },
    {
      "type": "stale",
      "reviewer": "AlexJerabek",
      "date": "2024-01-24T22:52:39.000Z",
      "abbrOid": "a3c33d0"
    }
  ],
  "mainBotCommentID": 1909025401,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Jan 24, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Action in New Pull Request Status Board Jan 24, 2024
@typescript-bot
Copy link
Contributor

🔔 @OfficeDev @Rick-Kirkham @AlexJerabek @ElizabethSamuel-MSFT @alison-mk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 24, 2024

It has been more than two weeks and this PR still has no reviews.

I'll bump it to the DT maintainer queue. Thank you for your patience, @samantharamon.

(Ping @OfficeDev, @Rick-Kirkham, @AlexJerabek, @ElizabethSamuel-MSFT, @alison-mk.)

types/office-js-preview/index.d.ts Outdated Show resolved Hide resolved
*
* - You can create custom classes that extend a default item class. For example, `IPM.Appointment.Contoso`.
*
* @param options - An object literal that contains one or more of the following properties:-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the '-' at the end of this line be on the next? This seems like a copy/paste problem elsewhere.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colon-dash format was previously agreed upon with editors to emphasize the list of properties of an object since we couldn't add a new line before the properties. I can look into other ways to better represent this in DT.

types/office-js-preview/index.d.ts Outdated Show resolved Hide resolved
*
* You can create custom classes that extend a default item class. For example, `IPM.Note.Contoso`.
*
* @param options - An object literal that contains one or more of the following properties:-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same ":-" comment.

@AlexJerabek
Copy link
Contributor

@samantharamon, approving with suggestions.

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jan 24, 2024
@RyanCavanaugh RyanCavanaugh moved this from Needs Maintainer Action to Waiting for Code Reviews in New Pull Request Status Board Jan 25, 2024
@typescript-bot typescript-bot added Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Jan 25, 2024
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board Jan 25, 2024
@samantharamon samantharamon marked this pull request as draft January 26, 2024 16:38
@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Needs Author Action in New Pull Request Status Board Jan 26, 2024
types/office-js/index.d.ts Outdated Show resolved Hide resolved
types/office-js-preview/index.d.ts Outdated Show resolved Hide resolved
@samantharamon samantharamon force-pushed the office-js-preview-item-properties branch from d442133 to 6c03444 Compare April 8, 2024 18:39
@samantharamon samantharamon marked this pull request as ready for review April 8, 2024 19:22
@typescript-bot typescript-bot added Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. and removed Self Merge This PR can now be self-merged by the PR author or an owner Owner Approved A listed owner of this package signed off on the pull request. labels Apr 8, 2024
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Action in New Pull Request Status Board Apr 8, 2024
@typescript-bot
Copy link
Contributor

@ndeleuze, @Rick-Kirkham, @AlexJerabek Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@ElizabethSamuel-MSFT ElizabethSamuel-MSFT merged commit b154281 into DefinitelyTyped:master Apr 9, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Needs Maintainer Action in New Pull Request Status Board Apr 9, 2024
@samantharamon samantharamon deleted the office-js-preview-item-properties branch April 9, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Edits multiple packages Popular package This PR affects a popular package (as counted by NPM download counts). Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants