-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[office-js][office-js-preview] (Outlook) Document additional mail item properties #67902
[office-js][office-js-preview] (Outlook) Document additional mail item properties #67902
Conversation
@samantharamon Thank you for submitting this PR! This is a live comment which I will keep updated. 2 packages in this PR
Code ReviewsThis PR can be merged once it's reviewed. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 115 days — it is still unreviewed! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 67902,
"author": "samantharamon",
"headCommitOid": "aa878944f016148b92f868de1d3ed384ebb14523",
"mergeBaseOid": "9b0f901d1017d4503b49629e672f8560dd88956e",
"lastPushDate": "2023-12-16T02:51:52.000Z",
"lastActivityDate": "2024-04-08T19:34:50.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "office-js-preview",
"kind": "edit",
"files": [
{
"path": "types/office-js-preview/index.d.ts",
"kind": "definition"
}
],
"owners": [
"OfficeDev",
"Rick-Kirkham",
"AlexJerabek",
"ElizabethSamuel-MSFT",
"alison-mk",
"samantharamon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "office-js",
"kind": "edit",
"files": [
{
"path": "types/office-js/index.d.ts",
"kind": "definition"
}
],
"owners": [
"OfficeDev",
"Rick-Kirkham",
"AlexJerabek",
"ElizabethSamuel-MSFT",
"alison-mk",
"samantharamon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "stale",
"reviewer": "ndeleuze",
"date": "2024-04-05T16:47:38.000Z",
"abbrOid": "d37c895"
},
{
"type": "stale",
"reviewer": "Rick-Kirkham",
"date": "2024-02-06T03:32:14.000Z",
"abbrOid": "a3c33d0"
},
{
"type": "stale",
"reviewer": "AlexJerabek",
"date": "2024-01-24T22:52:39.000Z",
"abbrOid": "a3c33d0"
}
],
"mainBotCommentID": 1909025401,
"ciResult": "pass"
} |
🔔 @OfficeDev @Rick-Kirkham @AlexJerabek @ElizabethSamuel-MSFT @alison-mk — please review this PR in the next few days. Be sure to explicitly select |
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @samantharamon. (Ping @OfficeDev, @Rick-Kirkham, @AlexJerabek, @ElizabethSamuel-MSFT, @alison-mk.) |
types/office-js-preview/index.d.ts
Outdated
* | ||
* - You can create custom classes that extend a default item class. For example, `IPM.Appointment.Contoso`. | ||
* | ||
* @param options - An object literal that contains one or more of the following properties:- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The colon-dash format was previously agreed upon with editors to emphasize the list of properties of an object since we couldn't add a new line before the properties. I can look into other ways to better represent this in DT.
types/office-js-preview/index.d.ts
Outdated
* | ||
* You can create custom classes that extend a default item class. For example, `IPM.Note.Contoso`. | ||
* | ||
* @param options - An object literal that contains one or more of the following properties:- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same ":-" comment.
@samantharamon, approving with suggestions. |
…conversationIndex to async method
d442133
to
6c03444
Compare
@ndeleuze, @Rick-Kirkham, @AlexJerabek Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review? |
pnpm test <package to test>
.If changing an existing definition: