New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react] fix: missing target types at KeyboardEvent #60696
Conversation
@ArthurPedroti Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 60696,
"author": "ArthurPedroti",
"headCommitOid": "5858dda7d8f63e5948024c2b421a3b7dbfdb1cc7",
"mergeBaseOid": "7714ca18128ad9f9d0f0bcc4dbd8e49ae07fa39f",
"lastPushDate": "2022-06-06T23:24:50.000Z",
"lastActivityDate": "2022-07-05T21:54:59.000Z",
"maintainerBlessed": "Waiting for Author to Merge",
"mergeOfferDate": "2022-07-05T21:44:41.000Z",
"mergeRequestDate": "2022-07-05T21:54:59.000Z",
"mergeRequestUser": "ArthurPedroti",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "react",
"kind": "edit",
"files": [
{
"path": "types/react/index.d.ts",
"kind": "definition"
}
],
"owners": [
"johnnyreilly",
"bbenezech",
"pzavolinsky",
"ericanderson",
"DovydasNavickas",
"theruther4d",
"guilhermehubner",
"ferdaber",
"jrakotoharisoa",
"pascaloliv",
"hotell",
"franklixuefei",
"Jessidhia",
"saranshkataria",
"lukyth",
"eps1lon",
"zieka",
"dancerphil",
"dimitropoulos",
"disjukr",
"vhfmag",
"hellatan",
"priyanshurav"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [],
"mainBotCommentID": 1148042626,
"ciResult": "pass"
} |
🔔 @johnnyreilly @bbenezech @pzavolinsky @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @eps1lon @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan @priyanshurav — please review this PR in the next few days. Be sure to explicitly select |
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. react (unpkg)was missing the following properties:
|
It has been more than two weeks and this PR still has no reviews. I'll bump it to the DT maintainer queue. Thank you for your patience, @ArthurPedroti. (Ping @johnnyreilly, @bbenezech, @pzavolinsky, @ericanderson, @DovydasNavickas, @theruther4d, @guilhermehubner, @ferdaber, @jrakotoharisoa, @pascaloliv, @Hotell, @franklixuefei, @Jessidhia, @saranshkataria, @lukyth, @eps1lon, @zieka, @dancerphil, @dimitropoulos, @disjukr, @vhfmag, @hellatan, @priyanshurav.) |
Ready to merge |
|
…types at KeyboardEvent by @ArthurPedroti" This reverts commit 2b52258.
@ArthurPedroti Sorry this slipped through. We'll have to revert this in #61124
We have this documented, though it might be easy to miss:
|
When you try to get the target.value at the Keyboard Event, you can't reach it, unlike the other events. For me, it's only a missing target types like other events have.
Sandbox with the errors reproduced: https://codesandbox.io/s/target-onkeydown-missing-type-kr46u1
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run
npm test <package to test>
.Provide a URL to documentation or source code which provides context for the suggested changes: https://codesandbox.io/s/target-onkeydown-missing-type-kr46u1