[yargs] fix: add a v15 folder without strictOptions

[forivall]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change.
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm test <package to test>.

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/yargs/yargs/blob/v16.0.0/CHANGELOG.md#1600-2020-09-09 - notably, strictOptions does not exist in yargs v15. it was added in feat: adds strictOptions() yargs/yargs#1738
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

See also: #48657 which added strictOptions typings, erroneously to v15

[typescript-bot]

@forivall Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• yargs on npm, on unpkg (author is owner)
  • Config files to check:
    • yargs/v15/tslint.json: not the expected form

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ❌ A DT maintainer needs to approve changes which affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 50717,
  "author": "forivall",
  "headCommitOid": "72cb30219ded5aa79b9fa554463f8f860e2e0f08",
  "lastPushDate": "2021-01-19T22:19:45.000Z",
  "lastActivityDate": "2021-01-29T00:28:04.000Z",
  "maintainerBlessed": false,
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "yargs",
      "kind": "edit",
      "files": [
        {
          "path": "types/yargs/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/yargs/v15/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/yargs/v15/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/yargs/v15/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson)"
        },
        {
          "path": "types/yargs/v15/yargs-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/yargs/v15/yargs.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "poelstra",
        "mizunashi-mana",
        "pushplay",
        "JimiC",
        "steffenvv",
        "forivall",
        "ExE-Boss",
        "Aankhen"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "sheetalkamat",
      "date": "2021-01-25T19:29:10.000Z"
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @poelstra @mizunashi-mana @pushplay @JimiC @steffenvv @ExE-Boss @Aankhen — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a version of yargs that doesn’t yet exist on master, so I’ve compared them with v15.0.

Comparison details 📊

	15.0@master	16.0 in #50717	diff
Batch compilation
Memory usage (MiB)	89.8	90.0	+0.2%
Type count	16916	16916	0%
Assignability cache size	2975	2975	0%
Language service
Samples taken	1559	1559	0%
Identifiers in tests	1559	1559	0%
getCompletionsAtPosition
Mean duration (ms)	365.2	364.5	-0.2%
Mean CV	9.3%	9.2%
Worst duration (ms)	805.8	778.7	-3.4%
Worst identifier	default	array
getQuickInfoAtPosition
Mean duration (ms)	360.0	359.8	0.0%
Mean CV	8.6%	8.6%
Worst duration (ms)	770.5	720.5	-6.5%
Worst identifier	positional	argv2

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[sheetalkamat]

There is no change between v16 and v15 currently. This change needs to be hold off if there is no change between these two versions

[forivall]

strictOptions doesn't exist in v15. That's the point of this change.

[sheetalkamat]

I dont see any change in v16? Can you point where the change is between v15 and v16 in these definitions?

[forivall]

.strictOptions exists here and i've removed it here. See the diff

[sheetalkamat]

Thank you. it got lost in big copy.. normally when versions change the change is in index.d.ts and not the older version. Thank you for the pointers.

[typescript-bot]

@forivall One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

[typescript-bot]

I just published @types/yargs@16.0.0 to npm.

[typescript-bot]

I just published @types/yargs@15.0.13 to npm.