New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webpack-manifest-plugin for Webpack 5 #50074
Update webpack-manifest-plugin for Webpack 5 #50074
Conversation
@alex996 Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 50074,
"author": "alex996",
"headCommitAbbrOid": "d6be528",
"headCommitOid": "d6be5287cf3ba4e94467eb930e704011725fbaa6",
"lastPushDate": "2020-12-11T00:54:10.000Z",
"lastActivityDate": "2020-12-11T04:15:48.000Z",
"maintainerBlessed": false,
"mergeOfferDate": "2020-12-11T04:14:00.000Z",
"mergeRequestDate": "2020-12-11T04:15:48.000Z",
"mergeRequestUser": "alex996",
"hasMergeConflict": false,
"isFirstContribution": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "webpack-manifest-plugin",
"kind": "edit",
"files": [
{
"path": "types/webpack-manifest-plugin/index.d.ts",
"kind": "definition"
},
{
"path": "types/webpack-manifest-plugin/webpack-manifest-plugin-tests.ts",
"kind": "test"
}
],
"owners": [
"r3nya",
"monsonjeremy"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "monsonjeremy",
"date": "2020-12-11T02:29:40.000Z",
"isMaintainer": false
}
],
"ciResult": "pass"
} |
🔔 @r3nya @monsonjeremy — please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
@alex996 Everything looks good here. Great job! I am ready to merge this PR (at d6be528) on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@r3nya, @monsonjeremy: you can do this too.) |
Ready to merge |
I just published |
Please fill in this template.
npm test webpack-manifest-plugin
.Select one of these and delete the others:
If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.Description:
Plugin
no longer works in Webpack 5:terser-webpack-plugin
. The fix follows the approach taken in copy-webpack-plugin. Tested with webpack v5.10.0