[yargs] Add .strictCommands definition to yargs typing.

[catdadcode]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: https://yargs.js.org/docs/#api-reference-strictcommandsenabledtrue
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• Include tests for your changes
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

[typescript-bot]

@Chevtek Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

1 package in this PR

• yargs on npm, on unpkg

Code Reviews

This PR can be merged once it's reviewed.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ❌ Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 31 days — it is considered abandoned!

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 46984,
  "author": "chevtek",
  "headCommitAbbrOid": "04c6dad",
  "headCommitOid": "04c6dad015d31155500225b05a8e61b9947813e6",
  "mergeIsRequested": true,
  "stalenessInDays": 31,
  "lastPushDate": "2020-08-23T08:53:53.000Z",
  "lastCommentDate": "2020-10-10T20:10:31.000Z",
  "maintainerBlessed": true,
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "yargs",
      "files": [
        {
          "path": "types/yargs/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "poelstra",
        "mizunashi-mana",
        "pushplay",
        "JimiC",
        "steffenvv",
        "forivall",
        "ExE-Boss",
        "Aankhen"
      ],
      "addedOwners": [
        "jeffkenney"
      ],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "NathanYocum",
      "date": "2020-09-22T17:29:59.000Z",
      "isMaintainer": false
    },
    {
      "type": "approved",
      "reviewer": "kirintwn",
      "date": "2020-09-08T06:49:35.000Z",
      "isMaintainer": false
    }
  ],
  "ciResult": "pass"
}

[typescript-bot]

🔔 @poelstra @mizunashi-mana @pushplay @JimiC @steffenvv @forivall @ExE-Boss @Aankhen — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#46984	diff
Batch compilation
Memory usage (MiB)	78.5	81.2	+3.4%
Type count	16091	16094	0%
Assignability cache size	2779	2780	0%
Language service
Samples taken	1503	1503	0%
Identifiers in tests	1503	1503	0%
getCompletionsAtPosition
Mean duration (ms)	378.8	378.2	-0.2%
Mean CV	7.7%	7.6%
Worst duration (ms)	610.4	597.5	-2.1%
Worst identifier	arg	arg
getQuickInfoAtPosition
Mean duration (ms)	373.6	373.5	0.0%
Mean CV	7.2%	7.3%	+1.7%
Worst duration (ms)	580.7	577.1	-0.6%
Worst identifier	argv2	argv2

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[kirintwn]

LGTM

[pushplay]

This has been approved for a while. Is there any reason this shouldn't go out?

[catdadcode]

Is there something else I need to do?

[pushplay]

Not as far as I can tell. It's just been stuck in this state for a while and I'm not sure why. Let's see if this works...

[pushplay]

Ready to merge

[pushplay]

Well that worked in #47867 so 🤷

[forivall]

@pushplay it has the "untested change" label on it, you need to modify the tests file i think

[typescript-bot]

@Chevtek Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

[typescript-bot]

@Chevtek I haven't seen any activity on this PR in more than 3 weeks, and this PR currently has problems that prevent it from being merged. The PR will be closed in a week if the issues aren't addressed.

[weswigham]

Hm, since this has a merge conflict, I'm going to close this PR. Feel free to open a new one if this change is still needed (since the process clearly got borked on this one).