Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react): Link better explanation for non-generic target #45663

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jun 23, 2020

JSDOC is visible in vscode.

The current link is not very helpful immediately and requires some navigating of linked prs/issues. At some point you land on #11508 (comment) which is in my opinion a better explanation. Especially because the very first sentence relates to the issue ("generic target").

@typescript-bot typescript-bot added Where is GH Actions? GH Actions didn't give a response to this PR Critical package Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Jun 23, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 23, 2020

@eps1lon Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can merge changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 45663,
  "author": "eps1lon",
  "owners": [
    "johnnyreilly",
    "bbenezech",
    "pzavolinsky",
    "digiguru",
    "ericanderson",
    "DovydasNavickas",
    "theruther4d",
    "guilhermehubner",
    "ferdaber",
    "jrakotoharisoa",
    "pascaloliv",
    "hotell",
    "franklixuefei",
    "Jessidhia",
    "saranshkataria",
    "lukyth",
    "eps1lon",
    "zieka",
    "dancerphil",
    "dimitropoulos",
    "disjukr",
    "vhfmag",
    "hellatan"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "b92142a",
  "headCommitOid": "b92142a7c7b4bd5939ce81697c4f4e99daea86b6",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastPushDate": "2020-06-23T14:03:08.000Z",
  "lastCommentDate": "2020-07-09T08:54:57.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45663/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Critical",
  "anyPackageIsNew": false,
  "packages": [
    "react"
  ],
  "files": [
    {
      "path": "types/react/index.d.ts",
      "kind": "definition",
      "package": "react"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-07-09T13:17:28.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @DovydasNavickas @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Jessidhia @saranshkataria @lukyth @zieka @dancerphil @dimitropoulos @disjukr @vhfmag @hellatan - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. and removed Where is GH Actions? GH Actions didn't give a response to this PR labels Jun 23, 2020
@typescript-bot typescript-bot moved this from Other to Waiting for Code Reviews in New Pull Request Status Board Jun 23, 2020
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jun 23, 2020
@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Jun 23, 2020
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Author Action in New Pull Request Status Board Jun 23, 2020
@typescript-bot
Copy link
Contributor

@eps1lon One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. If you disagree with the reviewer's comments, you can "dismiss" the review using GitHub's review UI. Thank you!

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #45663 diff
Batch compilation
Memory usage (MiB) 126.2 124.8 -1.2%
Type count 33062 33062 0%
Assignability cache size 8389 8389 0%
Language service
Samples taken 2360 2360 0%
Identifiers in tests 2771 2771 0%
getCompletionsAtPosition
    Mean duration (ms) 310.5 309.1 -0.5%
    Mean CV 6.7% 6.5%
    Worst duration (ms) 1005.4 1012.6 +0.7%
    Worst identifier props x
getQuickInfoAtPosition
    Mean duration (ms) 307.5 306.7 -0.2%
    Mean CV 6.9% 6.9% -0.5%
    Worst duration (ms) 814.8 832.8 +2.2%
    Worst identifier ref ref

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Jun 23, 2020
@typescript-bot typescript-bot added Unmerged The author did not merge the PR when it was ready. and removed Revision needed This PR needs code changes before it can be merged. labels Jul 9, 2020
@typescript-bot typescript-bot moved this from Needs Author Action to Needs Maintainer Review in New Pull Request Status Board Jul 9, 2020
@eps1lon
Copy link
Collaborator Author

eps1lon commented Jul 9, 2020

@RyanCavanaugh Why did the bot label this as "no one showed up to review" (Merge: YSYL)? Two owners approved this PR.

@typescript-bot typescript-bot removed the Unmerged The author did not merge the PR when it was ready. label Jul 9, 2020
@weswigham weswigham merged commit 1cdcf67 into DefinitelyTyped:master Jul 10, 2020
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board Jul 10, 2020
@typescript-bot
Copy link
Contributor

I just published @types/react@16.9.42 to npm.

ngbrown pushed a commit to ngbrown-forks/DefinitelyTyped that referenced this pull request Jul 11, 2020
danielrearden pushed a commit to danielrearden/DefinitelyTyped that referenced this pull request Sep 22, 2020
@eps1lon eps1lon deleted the feat/react/better-event-target-explanation branch June 23, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Critical package Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants