Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vimeo types to match current module #43278

Merged
merged 3 commits into from Mar 31, 2020

Conversation

mattleff
Copy link
Contributor

@mattleff mattleff commented Mar 20, 2020

The prior types at /vimeo/ were for a different package than vimeo. This PR aligns the types to match the current module. The prior types were for the same package as https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/vimeo__player/index.d.ts.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/vimeo/vimeo.js/blob/master/lib/vimeo.js.
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@mattleff mattleff marked this pull request as ready for review March 20, 2020 22:06
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Mar 20, 2020
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 20, 2020

@mattleff Thank you for submitting this PR!

🔔 @DazWilkin - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@DazWilkin
Copy link
Contributor

Once a committer, forever a reviewer!

I've not written TypeScript in years and am unable to review.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board Mar 25, 2020
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Mar 25, 2020
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@typescript-bot typescript-bot moved this from Review to Waiting for Reviewers in Pull Request Status Board Mar 25, 2020
@typescript-bot typescript-bot removed the Unmerged The author did not merge the PR when it was ready. label Mar 25, 2020
@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board Mar 30, 2020
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Mar 30, 2020
types/vimeo/index.d.ts Outdated Show resolved Hide resolved
@typescript-bot typescript-bot moved this from Review to Needs Author Attention in Pull Request Status Board Mar 31, 2020
@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Mar 31, 2020
@typescript-bot
Copy link
Contributor

@mattleff One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@typescript-bot
Copy link
Contributor

🔔 @uniqueiniquity - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@uniqueiniquity uniqueiniquity merged commit 68217d0 into DefinitelyTyped:master Mar 31, 2020
Pull Request Status Board automation moved this from Needs Author Attention to Done Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants