Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added typings for the webpack entry point for pdfjs-dist #36635

Merged

Conversation

maclockard
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • [ x Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Webpack instructions still cause 'fake worker' to load mozilla/pdf.js#7612 (comment)
    • there are no good docs outside of that comment, filed an issue on the repo to document
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 3, 2019

@maclockard Thank you for submitting this PR!

🔔 @jbaldwin @1999 - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

@maclockard The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@maclockard
Copy link
Contributor Author

@jbaldwin @1999 mind taking a look?

@typescript-bot typescript-bot moved this from Needs Author Attention to Waiting for Reviewers in Pull Request Status Board Jul 4, 2019
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #36635 diff
Batch compilation
Memory usage (MiB) 76.6 76.9 +0.4%
Type count 9000 9000 0.0%
Assignability cache size 32533 32533 0.0%
Subtype cache size 0 0
Identity cache size 3 3 0.0%
Language service
Samples taken 78 78 0.0%
Identifiers in tests 78 78 0.0%
getCompletionsAtPosition
    Mean duration (ms) 367.3 370.5 +0.9%
    Median duration (ms) 360.9 373.0 +3.3%
    Mean CV 12.9% 14.0% +8.5%
    Worst duration (ms) 495.5 473.0 -4.5%
    Worst identifier pdf pdf
getQuickInfoAtPosition
    Mean duration (ms) 345.7 348.7 +0.9%
    Median duration (ms) 344.8 345.7 +0.3%
    Mean CV 14.6% 15.2% +3.8%
    Worst duration (ms) 432.3 453.4 +4.9%
    Worst identifier Util renderPage

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Review in Pull Request Status Board Jul 9, 2019
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Jul 9, 2019
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@armanio123 armanio123 merged commit a4194e1 into DefinitelyTyped:master Jul 10, 2019
Pull Request Status Board automation moved this from Review to Done Jul 10, 2019
@typescript-bot
Copy link
Contributor

I just published @types/pdfjs-dist@2.0.1 to npm.

iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
…yped#36635)

* Added typings for the webpack entry point for pdfjs-dist

* fix tsconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unmerged The author did not merge the PR when it was ready.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants