Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic-pool should use PromiseLike, not Promise #23846

Merged

Conversation

wrboyce
Copy link
Contributor

@wrboyce wrboyce commented Feb 22, 2018

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes: <bluebird 3.0 definifion is not assignable to ES6 Promises #11027>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 26, 2018

@wrboyce Thank you for submitting this PR!

🔔 @jerray - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 27, 2018

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Feb 27, 2018
Copy link
Contributor

@jerray jerray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PromiseLike is better. thank you.

@typescript-bot typescript-bot moved this from Merge: YSYL to Merge: Express in Pull Request Triage Backlog Mar 1, 2018
@typescript-bot typescript-bot added Author Approved and removed Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Mar 1, 2018
@DanielRosenwasser DanielRosenwasser merged commit a8736ef into DefinitelyTyped:master Mar 1, 2018
@typescript-bot typescript-bot removed this from Merge: Express in Pull Request Triage Backlog Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants