New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node] [crypto] Added missing crypto update types #20561
Conversation
* Added DataView as type of crypto update functions
types/node/index.d.ts to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @tellnes @WilcoBakker @octo-sniffle @smac89 @Flarna @mwiktorczyk @wwwy3y3 @Tyriar @DeividasBakanas @kjin @alvis Microsoft TypeScript (account can't be detected)). Could you review this PR? |
@grantila Please fix the failures indicated in the Travis CI log. |
Held back due to #20308 I suppose... |
@grantila Please fix the failures indicated in the Travis CI log. |
@RyanCavanaugh no thanks, please fix #20308 instead... It just became impossible to contribute to this repo. I'm not sure how this is not top priority already... I've done my part. |
@grantila I think the CI setup for node has been changed to avoid the timeouts. You could try to merge in master to re-trigger CI. |
done |
Approved by a listed owner. PR ready to merge pending express review by a maintainer. |
[node] [crypto] Added missing crypto update types
Please fill in this template.
npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition: