Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] [crypto] Added missing crypto update types #20561

Merged
merged 2 commits into from Dec 13, 2017

Conversation

grantila
Copy link
Contributor

  • Added DataView as type of crypto update functions

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

 * Added DataView as type of crypto update functions
@dt-bot
Copy link
Member

dt-bot commented Oct 13, 2017

types/node/index.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @tellnes @WilcoBakker @octo-sniffle @smac89 @Flarna @mwiktorczyk @wwwy3y3 @Tyriar @DeividasBakanas @kjin @alvis Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

@typescript-bot
Copy link
Contributor

@grantila Please fix the failures indicated in the Travis CI log.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). The Travis CI build failed labels Oct 13, 2017
@grantila
Copy link
Contributor Author

Held back due to #20308 I suppose...

@RyanCavanaugh
Copy link
Member

@grantila Please fix the failures indicated in the Travis CI log.

@grantila
Copy link
Contributor Author

@RyanCavanaugh no thanks, please fix #20308 instead... It just became impossible to contribute to this repo. I'm not sure how this is not top priority already... I've done my part.

@Flarna
Copy link
Contributor

Flarna commented Nov 15, 2017

@grantila I think the CI setup for node has been changed to avoid the timeouts. You could try to merge in master to re-trigger CI.

@grantila
Copy link
Contributor Author

done

@typescript-bot
Copy link
Contributor

Approved by a listed owner. PR ready to merge pending express review by a maintainer.

@minestarks minestarks merged commit fa0b616 into DefinitelyTyped:master Dec 13, 2017
@typescript-bot typescript-bot removed this from Merge: Express in Pull Request Triage Backlog Dec 13, 2017
KSXGitHub pushed a commit to KSXGitHub/DefinitelyTyped that referenced this pull request May 12, 2018
[node] [crypto] Added missing crypto update types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants