Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node] Add Buffer.poolSize() and correct Buffer.byteLength() #20419

Merged
6 commits merged into from Oct 16, 2017
Merged

[node] Add Buffer.poolSize() and correct Buffer.byteLength() #20419

6 commits merged into from Oct 16, 2017

Conversation

Flarna
Copy link
Contributor

@Flarna Flarna commented Oct 9, 2017

fixes #20399 @vbodnia: would be nice if you can test in your environment
fixes #19930 @guftall: would be nice if you can test in your environment

@dt-bot
Copy link
Member

dt-bot commented Oct 9, 2017

types/node/index.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @robdesideri @tellnes @WilcoBakker @octo-sniffle @smac89 @mwiktorczyk @wwwy3y3 @Tyriar @DeividasBakanas @kjin @alvis Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Oct 9, 2017
@Flarna
Copy link
Contributor Author

Flarna commented Oct 9, 2017

Test failure look unrelated. Besides that travis times out...
@andy-ms @RyanCavanaugh : The list of node PRs lying around with unrelated CI fails grows. Any hints how to improve this?
see #20308, #20185, #20186, #20126, #20068, ...

@typescript-bot
Copy link
Contributor

@Flarna Please fix the failures indicated in the Travis CI log.

@ghost
Copy link

ghost commented Oct 16, 2017

@Flarna The way to improve it is for a human to go and actually look at the pull requests... Sorry for the delay.

@ghost ghost merged commit 2466ddb into DefinitelyTyped:master Oct 16, 2017
@Flarna
Copy link
Contributor Author

Flarna commented Oct 16, 2017

@andy-ms Thanks!
Maybe it's possible to improve the Bot to give people submitting a PR the possibility to to mark them as "CI fail is unrelated" and Bot puts them into the human queue.

@Flarna Flarna deleted the node_buffer_poolsize branch October 16, 2017 18:38
@ghost
Copy link

ghost commented Oct 16, 2017

Either a package should be merged or a human should look at it and help out. There's no third possibility or else we end up with 200 open pull requests.

KSXGitHub pushed a commit to KSXGitHub/DefinitelyTyped that referenced this pull request May 12, 2018
…elyTyped#20419)

* [node] Add Buffer.poolSize

* [node] Allow more types for Buffer.byteLength()

* fix lint issue
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@types/node Buffer: incorrect signature of byteLength() method @types/node Buffer.poolSize
3 participants