New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node] Add Buffer.poolSize() and correct Buffer.byteLength() #20419
Conversation
types/node/index.d.ts to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @robdesideri @tellnes @WilcoBakker @octo-sniffle @smac89 @mwiktorczyk @wwwy3y3 @Tyriar @DeividasBakanas @kjin @alvis Microsoft TypeScript (account can't be detected)). Could you review this PR? Checklist
|
@Flarna Please fix the failures indicated in the Travis CI log. |
@Flarna The way to improve it is for a human to go and actually look at the pull requests... Sorry for the delay. |
@andy-ms Thanks! |
Either a package should be merged or a human should look at it and help out. There's no third possibility or else we end up with 200 open pull requests. |
…elyTyped#20419) * [node] Add Buffer.poolSize * [node] Allow more types for Buffer.byteLength() * fix lint issue
npm run lint package-name
(ortsc
if notslint.json
is present).https://nodejs.org/dist/latest-v8.x/docs/api/buffer.html#buffer_class_property_buffer_poolsize
https://nodejs.org/dist/latest-v8.x/docs/api/buffer.html#buffer_class_method_buffer_bytelength_string_encoding
tslint.json
containing{ "extends": "dtslint/dt.json" }
.fixes #20399 @vbodnia: would be nice if you can test in your environment
fixes #19930 @guftall: would be nice if you can test in your environment