New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed dependence on "Bluebird". #16185
Conversation
types/sequelize/index.d.ts to authors (@samuelneff @CodeAnimal @drinchev @babolivier). Could you review this PR? Checklist
types/sequelize/v3/index.d.ts to authors (@samuelneff @CodeAnimal @drinchev). Could you review this PR? Checklist
|
This looked like a good idea. Can you mention why you closed this. Did you encounter any problems? |
@drinchev PromiseLike is not compatible with native Promise=( You can only remove the dependence on Bluebird, so that the sequelize was compatible with native Promise. |
Got it. Btw keep in mind that sequelize uses Bluebird as promise implementation. That's why I put it as a dependency in first place. If you remove bluebird dependency you will not have |
@drinchev The problem is that if I'm using a global bluebird because of performance:
But I do not use methods other than native ones. But because of the dependency of the secularize on the bluebird, the project is not going to. The Bluebird 3.0 is not compatible with the native Promise in the typescript-2.0 (#11027 (comment)). It turns out that, due to secularise, you have to import bliebird everywhere. This is a bluebird error, not sequelize! |
Please fill in this template.
npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
tslint.json
containing{ "extends": "dslint/dt.json" }
.