New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Bluebird to be assignable to ES2016 Promise. #11036
Allow Bluebird to be assignable to ES2016 Promise. #11036
Conversation
Add yet another one `.then` overloadings.
bluebird/bluebird.d.ts to author (@lhecker). Could you review this PR? Checklist
|
@Strate LGTM 🎉 To fix the failing tests I recommend replacing the |
I have made |
Unfortunately the Promise typings have changed in TS version 2 and so these typings no longer correspond: https://github.com/Microsoft/TypeScript/blob/070aa83cc06b2974639bbefcde98e6e2fb5fe693/src/lib/es2015.promise.d.ts |
^ What is the solution around this now? |
I'm working on a PR right now. I made the declaration of declare class Bluebird<R> implements Promise<R>, Bluebird.Inspection<R> { Problem is, I'm unsure as to how to get a reference to that "lib": [
"es2015.promise"
], |
@nfantone Don't forget to implement overloadings for all methods, which returns |
Yes, that's done. But still, I don't know what's the proper way of getting a reference to the native |
See ##11027