New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nodejs StringDecoder definition #10100

Merged

mhegazy merged 1 commit into DefinitelyTyped:master from Speedy37:master

Jul 20, 2016

Contributor

Speedy37 commented Jul 13, 2016

According to nodejs documentation the current definition of nodejs StringDecoder is invalid.

Reference:

The only change in the documentation between the 4 versions occurs between version 4 and 6 (latest).


          Fix nodejs StringDecoder definition

ac9a19d

Member

dt-bot commented Jul 13, 2016

node/node-0.10.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

Checklist

pass the Travis CI test?

node/node-0.11.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

Checklist

pass the Travis CI test?

node/node-0.12.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

Checklist

pass the Travis CI test?

node/node-4.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

Checklist

pass the Travis CI test?

node/node.d.ts

to authors (@DefinitelyTyped/DefinitelyTyped Microsoft TypeScript (account can't be detected)). Could you review this PR?
👍 or 👎?

Checklist

pass the Travis CI test?

mhegazy merged commit b54fdb6 into DefinitelyTyped:master

nquoctuan commented Jul 29, 2016 •

edited

Hi guys,
I am totally new to Typescript, Can anyone explain to me the code below that mark in red on Visual Studio? especial to ": this". I looked around on definition of class / interface, seems not support

I uses TypeScript 1.8
Thanks & regards,
Tuan

nquoctuan commented Jul 29, 2016

Hi there,

Is it that need to use TypeScript 2.0 ? from microsoft/TypeScript#3694

Thanks
Tuan

ligaz pushed a commit to ligaz/DefinitelyTyped that referenced this pull request


          Fix nodejs StringDecoder definition (DefinitelyTyped#10100)

c6eedca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment