🤖 Merge PR #69628 [video-react] Make all props of PlayerProps optiona…

…l by @Gcommer
DefinitelyTyped · May 17, 2024 · 425f0eb · 425f0eb
1 parent 4f7cc7d
commit 425f0eb
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 13 deletions.
diff --git a/types/video-react/index.d.ts b/types/video-react/index.d.ts
@@ -310,23 +310,23 @@ export interface PlayerProps extends RefAttributes<PlayerReference> {
     /**
      * Event on Play
      */
-    onPlay: () => void;
+    onPlay?: () => void;
     /**
      * Event on Ended
      */
-    onEnded: () => void;
+    onEnded?: () => void;
     /**
      * Event on Load start
      */
-    onLoadStart: () => void;
+    onLoadStart?: () => void;
     /**
      * Event on Pause start
      */
-    onPause: () => void;
+    onPause?: () => void;
     /**
      * Set the id of the video element.
      */
-    videoId: string;
+    videoId?: string;
 
     children?: React.ReactNode;
 }

diff --git a/types/video-react/video-react-tests.tsx b/types/video-react/video-react-tests.tsx
@@ -21,13 +21,23 @@ const testProps: PlayerProps = {
 
 function TestComponent(props: PlayerProps): React.JSX.Element {
     return (
-        <Player {...testProps}>
-            <ControlBar>
-                <CurrentTimeDisplay order={1} />
-                <DurationDisplay order={2} />
-                <ProgressControl order={3} />
-                <TimeDivider order={4} />
-            </ControlBar>
-        </Player>
+        <div>
+            <Player>
+                <ControlBar>
+                    <CurrentTimeDisplay order={1} />
+                    <DurationDisplay order={2} />
+                    <ProgressControl order={3} />
+                    <TimeDivider order={4} />
+                </ControlBar>
+            </Player>
+            <Player {...testProps}>
+                <ControlBar>
+                    <CurrentTimeDisplay order={1} />
+                    <DurationDisplay order={2} />
+                    <ProgressControl order={3} />
+                    <TimeDivider order={4} />
+                </ControlBar>
+            </Player>
+        </div>
     );
 }