-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Rain TVL including NFTs value #9721
base: main
Are you sure you want to change the base?
Conversation
…zed amounts and currency
Error while running adapter at projects/rain:
|
Error while running adapter at projects/rain:
|
Error while running adapter at projects/rain:
|
@solwhitey hi, what oracle is used here for pricing NFTs? |
Hey, it's our own in house oracle, it's the one also used to issue loans, So the floor price reported have to be correct lol. it has a 24 TWAP. |
hmm, the issue is, atm we are not including any nft outside of a few handful with chainlink support on ethereum as tvl if it was some external oracle like pyth, I could add price support for those solana nfts, sorry, but dont like the idea of using your in house oracle. Other issue of using oracle only here is, now, nfts are included in your tvl, but not for any other sol project with nft (that we have listed) |
do you know if pyth has nft pricing support for even some 3rd party service with open rest api? |
I don't agree with you on the first point. If our oracle return wrong data or faked floor price, we will get exploited instantly so our oracles HAVE to be correct. |
hi @solwhitey I am not questioning the accuracy of your oracle data. But prefer relying on a credibly neutral price feed, ideally 2-3 so, we are fine if one of them rugs us |
NOTE
Please enable "Allow edits by maintainers" while putting up the PR.
package-lock.json
file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CIHello! I added code to use our oracle to get the value of the collateralized nft