-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multibit add new chains base & savm & core #9666
base: main
Are you sure you want to change the base?
Conversation
pipi-multibit
commented
Apr 3, 2024
- Add base chain
- Add savm chain
- Add coreDAO chain
- Remove BSSB from the blacklist as it does not belong to the Multibit project.
Error while running adapter at projects/multibit:
|
], | ||
blacklistedTokens: ['MUBI', 'BSSB'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you removing BSSB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @g1nt0ki
BSSB is deployed by the Bitstable team and is not part of the Multibit team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but we have had this discussion in previous PRs and we clearly said we wont include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it was discussed in a previous PR. #8476
But this Token is not directly related to the project.
It is just one of the cross-chain assets, and users just bridge it.
It is similar to other coins.
I'd like to understand why you think it's relevant to the Multibit team?
Can you make a specific point? Our team needs to discuss it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because multibit and BSSB are closely linked. we do the same for other projects as well, like when abra team minted and deposited SPELL into sushiswap's bentobox, we excluded it from tvl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an important issue that our team is discussing.
Since BSSB is one of our main recommended cross-chain assets,
If blacklisted, the TVL of some cooperation chains will be 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @pipi-multibit
I checked what rest of the team thinks, sorry, they agree that we cant count BSSB
Error while running adapter at projects/multibit:
|
Error while running adapter at projects/multibit:
|