Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multibit add new chains base & savm & core #9666

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pipi-multibit
Copy link
Contributor

  1. Add base chain
  2. Add savm chain
  3. Add coreDAO chain
  4. Remove BSSB from the blacklist as it does not belong to the Multibit project.

@llamatester
Copy link

Error while running adapter at projects/multibit:

Error: 
    Unknown chain(s): savm, coreDAO
    Note: if you think that the chain is correct but missing from our list, please add it to 'projects/helper/chains.json' file
    
Error saving cache: Error: ENOENT: no such file or directory, open '/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/node_modules/@defillama/sdk/build/util/local_cache/zlib-1.0/BlockCache.json'
    at Object.openSync (node:fs:596:3)
    at Object.writeFileSync (node:fs:2322:35)
    at process.saveCache (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/node_modules/@defillama/sdk/build/util/cache.js:138:17)
    at process.emit (node:events:529:35)
    at process.exit (node:internal/process/per_thread:191:15)
    at process.handleError (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/utils/handleError.js:18:11)
    at process.emit (node:events:529:35)
    at emit (node:internal/process/promises:149:20)
    at processPromiseRejections (node:internal/process/promises:283:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: '/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/node_modules/@defillama/sdk/build/util/local_cache/zlib-1.0/BlockCache.json'
}

],
blacklistedTokens: ['MUBI', 'BSSB']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you removing BSSB?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @g1nt0ki
BSSB is deployed by the Bitstable team and is not part of the Multibit team.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but we have had this discussion in previous PRs and we clearly said we wont include it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was discussed in a previous PR. #8476

But this Token is not directly related to the project.
It is just one of the cross-chain assets, and users just bridge it.
It is similar to other coins.


I'd like to understand why you think it's relevant to the Multibit team?
Can you make a specific point? Our team needs to discuss it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because multibit and BSSB are closely linked. we do the same for other projects as well, like when abra team minted and deposited SPELL into sushiswap's bentobox, we excluded it from tvl.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an important issue that our team is discussing.

Since BSSB is one of our main recommended cross-chain assets,
If blacklisted, the TVL of some cooperation chains will be 0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @pipi-multibit
I checked what rest of the team thinks, sorry, they agree that we cant count BSSB

@llamatester
Copy link

Error while running adapter at projects/multibit:

Error: Failed to get https://open-api.unisat.io/v1/indexer/address/bc1p6r6hx759e3ulvggvd9x3df0rqh27jz59nvfjd2fzmh3wqyt6walq82u38z/brc20/summary
Truncated error stack:

    at get (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/projects/helper/http.js:33:11)
    at async sumTokens (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/projects/helper/chain/brc20.js:11:34)
    at async getTvl (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/test.js:49:23)
    at async /home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/test.js:139:9
    at async Promise.all (index 0)
    at async Promise.all (index 1)
    at async /home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/test.js:182:3

@llamatester
Copy link

Error while running adapter at projects/multibit:

Error: Failed to get https://open-api.unisat.io/v1/indexer/address/bc1p6r6hx759e3ulvggvd9x3df0rqh27jz59nvfjd2fzmh3wqyt6walq82u38z/brc20/summary
Truncated error stack:

    at get (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/projects/helper/http.js:33:11)
    at async sumTokens (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/projects/helper/chain/brc20.js:11:34)
    at async getTvl (/home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/test.js:49:23)
    at async /home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/test.js:139:9
    at async Promise.all (index 0)
    at async Promise.all (index 1)
    at async /home/runner/work/DefiLlama-Adapters/DefiLlama-Adapters/test.js:182:3

@pipi-multibit pipi-multibit changed the title Multibit add new chains base & savm & coreDAO Multibit add new chains base & savm & core Apr 3, 2024
@g1nt0ki g1nt0ki self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants