Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to use molecule 3D conformer #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OPAYA
Copy link
Contributor

@OPAYA OPAYA commented Oct 3, 2021

The 3D conformer coordinates are used in various model(SchNet, DimeNet, SpereNet, Graphormer).
Conformer generation code is added to contribute to more various model.

There are several methods of generating conformer provided by rdkit, but for now, the MMFF method was used.

@KiddoZhu
Copy link
Contributor

KiddoZhu commented Oct 3, 2021

Thanks! That's a good initiative. 3D conformers are really important for a wide range of tasks and models.

As conformer is not a necessary attribute to reconstruct a RDKit molecule, I would suggest reconsidering if we should put it as a precomputed attribute in data.Molecule.from_smiles or as a lazy attribute like data.Molecule.is_valid_rdkit. Additionally, providing an interface for different conformation generation methods would be nice.

We would come back to update your code and merge it.

@OPAYA
Copy link
Contributor Author

OPAYA commented Oct 3, 2021

Thanks for your response!

I considered because the conformer generation provided by Rdkit was not an accurate value.
Currently, I'm considering about implemented two versions of the conformers using rdkit's forcefield and the conformers calculated directly by the user through external software!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants