wdte: Fix comparison of floats. (#189)

DeedleFake · Jun 27, 2019 · 0aeaf58 · 0aeaf58
1 parent f0eaaa4
commit 0aeaf58
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/types.go b/types.go
@@ -113,11 +113,18 @@ func (n Number) Call(frame Frame, args ...Func) Func { // nolint
 
 func (n Number) Compare(other Func) (int, bool) { // nolint
 	o, ok := other.(Number)
-	if !ok {
+
+	switch {
+	case !ok:
 		return -1, false
-	}
 
-	return int(n - o), true
+	case n < o:
+		return -1, true
+	case n > o:
+		return 1, true
+	default:
+		return 0, true
+	}
 }
 
 func (n Number) String() string { // nolint

diff --git a/wdte_test.go b/wdte_test.go
@@ -190,6 +190,11 @@ func TestBasics(t *testing.T) {
 			script: `let test => +; test 3 5;`,
 			ret:    wdte.Number(8),
 		},
+		{
+			name:   "Simple/Number/Compare",
+			script: `[< .2 .5; < .6 .5; > .2 .5; > .6 .5];`,
+			ret:    wdte.Array{wdte.Bool(true), wdte.Bool(false), wdte.Bool(false), wdte.Bool(true)},
+		},
 		{
 			name:   "Simple/String/Compare",
 			script: `[< 'a' 'b'; > 'a' 'b'];`,