task: adding local deploy targets #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsloughter
reviewed
Mar 11, 2024
make/Makefile-local-install
Outdated
| @echo "🟢 Start mdai-system-reqs..." | ||
| @go version || brew list go || brew install go \ | ||
| kubectl version || brew list kubectl || brew install kubectl \ | ||
| npm -v || brew list npm || brew install npm \ |
There was a problem hiding this comment.
Why is npm needed? I don't see it used, but maybe some other command is using it?
There was a problem hiding this comment.
good call out, npm is needed for AWS (cdk) but not local install
tsloughter
reviewed
Mar 11, 2024
make/Makefile-local-install
Outdated
| .PHONY: mdai-system-reqs | ||
| mdai-system-reqs: | ||
| @echo "🟢 Start mdai-system-reqs..." | ||
| @go version || brew list go || brew install go \ |
There was a problem hiding this comment.
Is go needed for like brew install kubectl?
arcanez
requested changes
Mar 11, 2024
| schedule: "*/1 * * * *" | ||
| concurrencyPolicy: Forbid | ||
| successfulJobsHistoryLimit: 1 |
There was a problem hiding this comment.
curious why this was removed
tsloughter
reviewed
Mar 11, 2024
Co-authored-by: Justin Hunter <arcanez@users.noreply.github.com>
| mdai-install-helm-charts: | ||
| @echo "🟢 Start mdai-install-helm-charts..." | ||
| helm repo update | ||
| helm upgrade -f ./templates/prometheus-values.yaml prometheus prometheus-community/prometheus --install --wait |
There was a problem hiding this comment.
I fixed a file path here, changing prometheus_values.yaml to prometheus-values.yaml when I did my tabs fixes. However I think maybe the values in that file actually might break the metrics scraping 😬 Mine no longer seem to work, but that could be specific to my setup
arcanez
approved these changes
Mar 11, 2024
arcanez
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide for reviewers?
These are the relevant steps for a local engine install.
What is the focus or goal of the code changes?
Provide a local approach to test the tech before deploying to a CSP like AWS.
Where should the reviewer start?
README.mdln. 29Does this add new dependencies? Is there an installation or build procedure?
Yes, there are 4 new build procedures.
1.
make -f ./make/Makefile-local-recipies create-mdaideploy a local cluster from scratch2.
make -f ./make/Makefile-local-recipies delete-mdaideletes mdai cluster deployed locally and all artifacts associated3.
make -f ./make/Makefile-local-recipies delete-mdai-alldeletes mdai cluster deployed locally and all artifacts associated, plus helm charts4.
make -f ./make/Makefile-local-recipies update-mdai-collectorupdates mdai the collector to the latest configurationHow should this be manually tested?
Run each of the commands in their correct use as called out above.
Screenshots (if applicable)
n/a
Optional: What gif best describes this PR or how it makes you feel?