create self-signed cert and import into ACM #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o11yguru
approved these changes
Mar 5, 2024
s0b01ev
approved these changes
Mar 5, 2024
o11ies
reviewed
Mar 5, 2024
| .SILENT: cert | ||
| cert: | ||
| ACM_ARN=$(shell openssl req -new -x509 -sha256 -nodes -newkey rsa:4096 -keyout /tmp/private_mdai.key -out /tmp/certificate_mdai.crt -subj "/CN=${MDAI_UI_HOSTNAME}" && \ | ||
| aws acm import-certificate --region ${AWS_REGION} --certificate fileb:///tmp/certificate_mdai.crt --private-key fileb:///tmp/private_mdai.key --output text) ; \ |
There was a problem hiding this comment.
I think we should do an error handling here for the case when aws acm import-certificate fails.
There was a problem hiding this comment.
what should happen in the event of a failure?
There was a problem hiding this comment.
User should see the error, so they would know that certificate was not created successfully and ideally the reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide for reviewers?
What is the focus or goal of the code changes?
create self-signed cert and import into ACM
Where should the reviewer start?
Does this add new dependencies? Is there an installation or build procedure?
opensslandawsbinaries (required for this step, optional overall)How should this be manually tested?
make certScreenshots (if applicable)
Optional: What gif best describes this PR or how it makes you feel?