Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: replace WebView with WKWebView #1457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sgsm74
Copy link

@sgsm74 sgsm74 commented Aug 12, 2023

'WebView' was deprecated in macOS 10.14: No longer supported

'WebView' was deprecated in macOS 10.14: No longer supported
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (90ad768) 36.25% compared to head (5931883) 36.25%.
Report is 2 commits behind head on master.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1457   +/-   ##
=======================================
  Coverage   36.25%   36.25%           
=======================================
  Files         140      140           
  Lines       21644    21644           
=======================================
  Hits         7848     7848           
  Misses      13796    13796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavBfr
Copy link
Owner

DavBfr commented Aug 12, 2023

It seems that's not enough.

@DavBfr
Copy link
Owner

DavBfr commented Aug 12, 2023

I have a branch with WKWebView but it's incompatible with macOS < 11.0

@DavBfr
Copy link
Owner

DavBfr commented Aug 12, 2023

d19639f

Copy link
Contributor

@Baghdady92 Baghdady92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants