Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to polkadot latest version #241

Open
wants to merge 20 commits into
base: make_compatible_with_kusama
Choose a base branch
from

Conversation

ayushmishra2005
Copy link
Contributor

No description provided.

node/src/command.rs Outdated Show resolved Hide resolved
runtime/Cargo.toml Outdated Show resolved Hide resolved
runtime/Cargo.toml Outdated Show resolved Hide resolved
runtime/Cargo.toml Outdated Show resolved Hide resolved
impl WeightToFeePolynomial for WeightToFee {
type Balance = Balance;
fn polynomial() -> WeightToFeeCoefficients<Self::Balance> {
// in Rococo, extrinsic base weight (smallest non-zero weight) is mapped to 1 MILLIUNIT:
Copy link
Collaborator

@ltfschoen ltfschoen Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you discussed these proposed values for p and q and WeightToFeeCoefficient field values with the team?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added details in shared sheet Runtime Upgrade Values

Copy link
Collaborator

@ltfschoen ltfschoen Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of storing them in an internal spreadsheet, could you please create a Github issue for each of the Runtime Upgrade Values that haven't been resolved.
ideally the comments associated with these Runtime Upgrade Values should be included as comments in the code so it appears in the documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raised here #246

runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@ltfschoen ltfschoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i haven't tried running this, i've only reviewed the code and left comments.
if you think it's necessary for me to run it please share instructions

@ltfschoen
Copy link
Collaborator

@ayushmishra2005 please DM me when you've responded to all the questions and made the linting changes so i can respond if necessary all at once

@ayushmishra2005 ayushmishra2005 changed the title Updated to polkadot0.9.11 Updated to polkadot latest version Dec 23, 2021
@ayushmishra2005
Copy link
Contributor Author

i haven't tried running this, i've only reviewed the code and left comments. if you think it's necessary for me to run it please share instructions

@ltfschoen I have tested it locally. Its working fine. However if you want to test, you can follow https://docs.substrate.io/tutorials/v3/cumulus/start-relay/ and replace parachain-collator with datahighway-collator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants