Updating helm chart #130
Open
Updating helm chart #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge when 0.4.o is released. |
clamoriniere
reviewed
Feb 1, 2022
| @@ -25,9 +31,12 @@ spec: | |||
| - JSONPath: .spec.maxReplicas | |||
| name: max replicas | |||
| type: integer | |||
| - JSONPath: .spec.dryRun | |||
| - JSONPath: .status.conditions[?(@.type=="DryRun")].status | |||
There was a problem hiding this comment.
This is what I was talking about during the standup.
clamoriniere
reviewed
Feb 1, 2022
Comment on lines
+10
to
+15
| - JSONPath: .status.conditions[0].type | ||
| name: condition | ||
| type: string | ||
| - JSONPath: .status.conditions[0].status | ||
| name: condition status | ||
| type: string |
There was a problem hiding this comment.
how can we be sure it is always the first item in the conditions slice?
clamoriniere
reviewed
Feb 1, 2022
| ddProfiling: | ||
| enabled: false | ||
|
|
||
| workers: 1 |
There was a problem hiding this comment.
IMO to be backward compatible the workers value should be empty. because here you will always add the new args that doesn't exist on previous version.
OR, you add an if in the template file. Something like
{{- if no eq (int .Values.workers) 1 }}
- -workers={{ .Values.workers }}
{{- end }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upon merging releasing 0.4.0, we update the chart.
Motivation
seamless upgrade experience for users.
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.