Add runtime guardrail for SSI #4319
Draft
+434
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 6.48 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-06-05 04:12:19 Comparing candidate commit a446f9a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics. |
When in SSI, bail out if our version of Node.js is incompatible.
bengl
force-pushed
the
bengl/runtime-guardrails
branch
from
74ff0c6
to
7a88c4f
Compare
Qard
previously approved these changes
May 17, 2024
simon-id
reviewed
May 17, 2024
| it('should initialize the tracer, if DD_INJECTION_ENABLED', () => { | ||
| return runTest(cwd, { NODE_OPTIONS, DD_INJECTION_ENABLED }, 'true\n') | ||
| context('when node version is more than engines field', () => { | ||
| const FAKE_VERSION = '50000.0.0' |
There was a problem hiding this comment.
make sure to update this in april of the year 27002, when node 50000 releases
There was a problem hiding this comment.
Maybe I should use Number.MAX_SAFE_INTEGER instead?
simon-id
previously approved these changes
May 17, 2024
bengl
force-pushed
the
bengl/runtime-guardrails
branch
from
aefbd02
to
947e5d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in SSI, bail out if our version of Node.js is incompatible.