Move to google.golang.org/protobuf #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piochelepiotr
force-pushed
the
piotr-wolski/update-protobuf
branch
from
f47f499
to
ab3f642
Compare
felixge
approved these changes
May 14, 2024
There was a problem hiding this comment.
LGTM, but the CI failure needs to be fixed before merging.
Also needs a DSM member to approve.
gabe-ochoa
approved these changes
May 14, 2024
BenchmarksBenchmark execution time: 2024-05-14 19:26:25 Comparing candidate commit ab3f642 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 0 unstable metrics. |
felixge
reviewed
May 15, 2024
| @@ -36,7 +36,6 @@ github.com/golang/mock v1.6.0/go.mod h1:p6yTPP+5HYm5mzsMV8JkE6ZKdX+/wYM6Hr+Licev | |||
| github.com/golang/protobuf v1.5.0/go.mod h1:FsONVRAS9T7sI+LIUmWTfcYkHO4aIWwzhcaSAoJOfIk= | |||
| github.com/golang/protobuf v1.5.2/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiuN0vRsmY= | |||
| github.com/golang/protobuf v1.5.3 h1:KhyjKVUg7Usr/dYsdSqoFveMYd5ko72D+zANwlG1mmg= | |||
| github.com/golang/protobuf v1.5.3/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiuN0vRsmY= | |||
There was a problem hiding this comment.
Why are the older version entries still in here?
There was a problem hiding this comment.
@felixge It seems that running go mod tidy doesn't remove them. It seems to be a transitive dependency from github.com/DataDog/sketches-go/ddsketch:
❯ go mod why -m github.com/golang/protobuf
# github.com/golang/protobuf
github.com/DataDog/dd-trace-go/internal/apps
gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer
github.com/DataDog/sketches-go/ddsketch
github.com/DataDog/sketches-go/ddsketch.test
github.com/golang/protobuf/proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stop using deprecated library for Protobuf (github.com/golang/protobuf/proto)
Motivation
Follow up to #1136
Reviewer's Checklist
Unsure? Have a question? Request a review!