-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/database/sql: allow peer.service to be set explicitly and add into propagated context #2679
Merged
+144
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
apm:ecosystem
contrib/* related feature requests or bugs
label
May 1, 2024
BenchmarksBenchmark execution time: 2024-05-22 14:35:14 Comparing candidate commit 26753a3 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 0 unstable metrics. |
tabgok
commented
May 7, 2024
tabgok
force-pushed
the
teague.bick/AIT-10033/dbm-peer-entity
branch
from
May 10, 2024 12:31
520f307
to
6d3dac2
Compare
rarguelloF
reviewed
May 14, 2024
… into propagated context
tabgok
force-pushed
the
teague.bick/AIT-10033/dbm-peer-entity
branch
from
May 15, 2024 12:23
ccdb257
to
dde9ab3
Compare
rarguelloF
reviewed
May 20, 2024
rarguelloF
approved these changes
May 20, 2024
dianashevchenko
approved these changes
May 22, 2024
tabgok
changed the title
contrib/database/sql: allow peer.service to be set explicitly and add…
contrib/database/sql: allow peer.service to be set explicitly and add into propagated context
May 22, 2024
/merge |
@tabgok I'll handle the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does two things:
peer.service
to the SQL Connection context if set explicitly by a user via the Traced Connector Context or tagddprs=peer.service
to the SQL Comment propagation when full mode is enabledMotivation
This change allows the DBM and APM service maps to line up
Reviewer's Checklist
Unsure? Have a question? Request a review!