(dyngo): move out of /internal/
#2675
Draft
+2,133
−1,339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
apm:ecosystem
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -72,21 +94,27 @@ func newWafEventListener(wafHandle *waf.Handle, cfg *config.Config, limiter limi | |||
|
|
|||
| // NewWAFEventListener returns the WAF event listener to register in order | |||
| // to enable it. | |||
| func (l *wafEventListener) onEvent(request *types.RequestOperation, _ types.RequestOperationArgs) { | |||
| func (l *wafEventListener) onEvent(request *graphqlevent.RequestOperation, args graphqlevent.RequestOperationArgs) { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _ (revive)
|
I am actively wondering whether we should move dyngo straight into orchestrion [or not [yet]]. |
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR moves Dyngo out of
/internal/appsecso it can be safely depended upon by external packages. It also includes the necessary accompanying refactors.Motivation
This is to allow
orchestrionto use this API in code it injects without creating opaque cross-package dependencies (that would be too brittle).Partially contributes to DataDog/orchestrion#86
Reviewer's Checklist
Unsure? Have a question? Request a review!