-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appsec: upgrade go-libddwaf/v3 #2670
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-05-21 14:10:46 Comparing candidate commit 5014170 in PR branch Found 0 performance improvements and 6 performance regressions! Performance is the same for 38 metrics, 0 unstable metrics. scenario:BenchmarkPartialFlushing/Disabled-24
scenario:BenchmarkPartialFlushing/Enabled-24
scenario:BenchmarkSingleSpanRetention/no-rules-24
scenario:BenchmarkSingleSpanRetention/with-rules/match-all-24
scenario:BenchmarkSingleSpanRetention/with-rules/match-half-24
scenario:BenchmarkStartSpan-24
|
Hellzy
force-pushed
the
francois.mazeau/go-libddwaf-update
branch
3 times, most recently
from
May 16, 2024 11:14
05ebeb2
to
3d7e973
Compare
Hellzy
force-pushed
the
francois.mazeau/go-libddwaf-update
branch
3 times, most recently
from
May 16, 2024 12:20
a579afc
to
8ec5ab2
Compare
Hellzy
force-pushed
the
francois.mazeau/go-libddwaf-update
branch
from
May 21, 2024 13:04
d72b505
to
0b0aced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
JIRA: APPSEC-53057
Upgrades the go-libddwaf dependency to v3.
In v3, actions are now returned as a
map[string]any
mapping action types to their parameters.Parameters, while technicaly described as a
map[string]any
, are actuallymap[string]string
(i.e all param values are provided as strings).Another important change is that actions are new more granular. When generating a block action, a GRPC and an HTTP
block action are now emitted, instead of a single monolithic block action.
Similarly, listeners can now listen for those actions individually.
This whole split removes a big layer of complexity.
Changes
Motivation
Reviewer's Checklist
Unsure? Have a question? Request a review!