-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiler: enable endpoint call counts by default #2590
base: main
Are you sure you want to change the base?
profiler: enable endpoint call counts by default #2590
Conversation
BenchmarksBenchmark execution time: 2024-03-01 07:39:45 Comparing candidate commit 4233c7c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics. |
Note: PR #1845 disabled |
Note: I checked the output of the benchmark pipeline and verified that |
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been open for 30 days with no activity. |
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
DO NOT MERGE YET
What does this PR do?
Enables #1552 by default for profiling+tracing users. This adds a small critical section updating counters in a map in the span creation hot path. But the impact of this is not measurable in our span creation benchmarks (both concurrent and single goroutine flavors) as demonstrated by this PR.
The absolute worst-case estimate I have is an additional latency of ~150ns/span under a maximum contention that is probably 10-100x worse than anything that can be achieved in the real world. Without contention this feature should add ~20ns latency per span (~1%). See this gist for more details.
Motivation
Provides a way to measure the CPU Time per Request which is very useful for evaluating the impact of profile guided optimization.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!