[ASCII-1613] Split dogstatsd/replay into new component hierarchy
#25512
Conversation
pgimalac
added
changelog/no-changelog
team/agent-metrics-logs
component framework
qa/done
Go Package Import DifferencesBaseline: d9ff65e
|
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=35062935 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: 9d6df802-6e65-4bc9-a2ab-9e68b8f525e5 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | basic_py_check | % cpu utilization | +1.75 | [-0.71, +4.22] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.76 | [-2.17, +3.69] |
| ➖ | idle | memory utilization | +0.18 | [+0.15, +0.22] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.03 | [+0.00, +0.06] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.01 | [-0.00, +0.01] |
| ➖ | trace_agent_json | ingress throughput | +0.00 | [-0.01, +0.02] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.22, +0.19] |
| ➖ | otel_to_otel_logs | ingress throughput | -0.04 | [-0.39, +0.32] |
| ➖ | file_tree | memory utilization | -0.68 | [-0.76, -0.60] |
| ➖ | pycheck_1000_100byte_tags | % cpu utilization | -2.70 | [-7.23, +1.83] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -3.10 | [-23.38, +17.17] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
pgimalac
force-pushed
the
pgimalac/dsd-replay-split
branch
from
5ec9800
to
42eaaff
Compare
pgimalac
force-pushed
the
pgimalac/dsd-replay-split
branch
from
42eaaff
to
7636d9b
Compare
pgimalac
force-pushed
the
pgimalac/dsd-replay-split
branch
from
1532005
to
793d284
Compare
…/dsd-replay-split
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25512 +/- ##
===========================================
+ Coverage 44.95% 46.82% +1.87%
===========================================
Files 2328 251 -2077
Lines 268349 21912 -246437
===========================================
- Hits 120644 10261 -110383
+ Misses 138111 11155 -126956
+ Partials 9594 496 -9098
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 30m) Use |
|
❌ MergeQueue Build pipeline has failing jobs for 7e41d6b Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. You should have a look at the pipeline, wait for the build to finish and investigate the failures.
|
|
/merge |
|
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
…/dsd-replay-split
|
/merge -c |
|
/merge |
|
This merge request was unqueued If you need support, contact us on Slack #devflow! |
|
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
Serverless Benchmark Results
tl;drUse these benchmarks as an insight tool during development.
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
I need more helpFirst off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development. If you would like a hand interpreting the results come chat with us in Benchmark stats |
|
This merge request was unqueued If you need support, contact us on Slack #devflow! |
|
/merge |
|
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
|
🚂 MergeQueue Pull request added to the queue. There are 2 builds ahead! (estimated merge in less than 1h) Use |
What does this PR do?
Split
comp/dogstats/replayinto multiple packages for the component, fx, and implementations.Motivation
Removing some dependencies from serverless.
When everything is in the same package you get everything at once whether you want it or not.
Additional Notes
This PR should be easier to review commit by commit:
Remaining commits are small and address review comments.
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
QA is handled in #25442