Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fleet) move the installer run path to /var/run/datadog/installer #25509

Merged
merged 13 commits into from May 15, 2024

Conversation

arbll
Copy link
Member

@arbll arbll commented May 10, 2024

This PR moves all the runtime on-disk state of the installer to /var/run/datadog/installer.

@arbll arbll added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/fleet-automation labels May 10, 2024
@arbll arbll requested review from a team as code owners May 10, 2024 14:28
@pr-commenter
Copy link

pr-commenter bot commented May 10, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=34351863 --os-family=ubuntu

@pr-commenter
Copy link

pr-commenter bot commented May 10, 2024

Regression Detector

Regression Detector Results

Run ID: 67c8618e-dc07-440e-9d50-4185d8d3c20b
Baseline: 66fd1e4
Comparison: 078cf09

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +0.54 [-2.31, +3.39]
uds_dogstatsd_to_api ingress throughput +0.02 [-0.19, +0.22]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.05, +0.04]
otel_to_otel_logs ingress throughput -0.06 [-0.42, +0.31]
idle memory utilization -0.25 [-0.28, -0.21]
basic_py_check % cpu utilization -0.38 [-2.71, +1.95]
file_tree memory utilization -0.85 [-0.95, -0.76]
tcp_syslog_to_blackhole ingress throughput -2.01 [-22.42, +18.40]
pycheck_1000_100byte_tags % cpu utilization -2.11 [-6.69, +2.47]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@arbll
Copy link
Member Author

arbll commented May 15, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 15, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

KevinFairise2
KevinFairise2 previously approved these changes May 15, 2024
pkg/fleet/installer/service/datadog_installer.go Outdated Show resolved Hide resolved
@dd-devflow
Copy link

dd-devflow bot commented May 15, 2024

🚂 MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

@KevinFairise2 KevinFairise2 dismissed their stale review May 15, 2024 12:44

Otherwise it will be merged automatically

Co-authored-by: Florent Clarret <florent.clarret@datadoghq.com>
@dd-devflow
Copy link

dd-devflow bot commented May 15, 2024

❌ MergeQueue

This PR is rejected because it was updated

If you need support, contact us on Slack #devflow with those details!

Co-authored-by: Kevin Fairise <132568982+KevinFairise2@users.noreply.github.com>
@BaptisteFoy
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 15, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented May 15, 2024

🚂 MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit f70fbf1 into main May 15, 2024
210 of 215 checks passed
@dd-mergequeue dd-mergequeue bot deleted the arbll/daemon-run-path branch May 15, 2024 14:15
@github-actions github-actions bot added this to the 7.55.0 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants