Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fleet) store package installation in a bbolt db #25506

Merged
merged 9 commits into from May 13, 2024
Merged

(fleet) store package installation in a bbolt db #25506

merged 9 commits into from May 13, 2024

Conversation

arbll
Copy link
Member

@arbll arbll commented May 10, 2024

  • Adds a DB that stores installed packages
  • Add is-installed

@arbll arbll added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/fleet-automation labels May 10, 2024
@arbll arbll requested a review from a team as a code owner May 10, 2024 13:21
@pr-commenter
Copy link

pr-commenter bot commented May 10, 2024

Regression Detector

Regression Detector Results

Run ID: 73e7d74e-63df-471b-8643-3176427d2cf6
Baseline: 83418a3
Comparison: 3e3e52e

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.68 [-5.22, +8.59]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +10.00 [-12.34, +32.34]
file_to_blackhole % cpu utilization +1.68 [-5.22, +8.59]
otel_to_otel_logs ingress throughput +0.11 [-0.26, +0.48]
tcp_dd_logs_filter_exclude ingress throughput +0.05 [+0.02, +0.07]
trace_agent_json ingress throughput +0.01 [-0.01, +0.03]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
idle memory utilization -0.62 [-0.67, -0.58]
pycheck_1000_100byte_tags % cpu utilization -0.82 [-5.56, +3.92]
file_tree memory utilization -1.31 [-1.39, -1.22]
basic_py_check % cpu utilization -1.66 [-4.09, +0.77]
uds_dogstatsd_to_api_cpu % cpu utilization -2.54 [-5.34, +0.25]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pr-commenter
Copy link

pr-commenter bot commented May 11, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=34087786 --os-family=ubuntu

Copy link
Contributor

@raphaelgavache raphaelgavache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ReturnCodeIsInstalledFalse = 10
)

func isInstalledCommand() *cobra.Command {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this command should be added in the e2e tests (agent, auto_inject, java tracer)

@arbll
Copy link
Member Author

arbll commented May 13, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 13, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 26m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit d99fbe0 into main May 13, 2024
203 checks passed
@dd-mergequeue dd-mergequeue bot deleted the arbll/db branch May 13, 2024 07:24
@github-actions github-actions bot added this to the 7.55.0 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants