New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fleet) store package installation in a bbolt db #25506
Conversation
Regression DetectorRegression Detector ResultsRun ID: 73e7d74e-63df-471b-8643-3176427d2cf6 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | +1.68 | [-5.22, +8.59] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +10.00 | [-12.34, +32.34] |
➖ | file_to_blackhole | % cpu utilization | +1.68 | [-5.22, +8.59] |
➖ | otel_to_otel_logs | ingress throughput | +0.11 | [-0.26, +0.48] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.05 | [+0.02, +0.07] |
➖ | trace_agent_json | ingress throughput | +0.01 | [-0.01, +0.03] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.20, +0.20] |
➖ | trace_agent_msgpack | ingress throughput | -0.00 | [-0.00, +0.00] |
➖ | idle | memory utilization | -0.62 | [-0.67, -0.58] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -0.82 | [-5.56, +3.92] |
➖ | file_tree | memory utilization | -1.31 | [-1.39, -1.22] |
➖ | basic_py_check | % cpu utilization | -1.66 | [-4.09, +0.77] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -2.54 | [-5.34, +0.25] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=34087786 --os-family=ubuntu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ReturnCodeIsInstalledFalse = 10 | ||
) | ||
|
||
func isInstalledCommand() *cobra.Command { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this command should be added in the e2e tests (agent, auto_inject, java tracer)
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 26m) Use |
is-installed