New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[windows][cws][wkint-495] Add additional statistics to the security p… #25495
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=34208713 --os-family=ubuntu |
Regression DetectorRegression Detector ResultsRun ID: 5d92eaf7-56a6-44cd-9bce-20d19205336f Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | -0.83 | [-2.08, +0.43] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_tree | memory utilization | +0.38 | [+0.28, +0.48] |
➖ | otel_to_otel_logs | ingress throughput | +0.11 | [-0.26, +0.48] |
➖ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | trace_agent_json | ingress throughput | -0.00 | [-0.01, +0.01] |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.20, +0.20] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.05, +0.04] |
➖ | idle | memory utilization | -0.23 | [-0.27, -0.19] |
➖ | basic_py_check | % cpu utilization | -0.57 | [-2.82, +1.68] |
➖ | file_to_blackhole | % cpu utilization | -0.83 | [-2.08, +0.43] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.17 | [-3.99, +1.65] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -2.23 | [-7.04, +2.58] |
➖ | tcp_syslog_to_blackhole | ingress throughput | -2.31 | [-23.15, +18.54] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
intermediate checking. Have standalone commit to allow changing number of ETW buffers add ability to get etw stats clean up cherry-pick
…robe Title says it all. Add a bunch of statistics for internal profiling of performance of the system probe cws functionality.
7a81491
to
77489b6
Compare
/merge |
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 51m) Use |
DataDog#25495) * [windows] Update ETW with new functions; add ability to get ETW stats intermediate checking. Have standalone commit to allow changing number of ETW buffers add ability to get etw stats clean up cherry-pick * [windows][cws][wkint-495] Add additional statistics to the security probe Title says it all. Add a bunch of statistics for internal profiling of performance of the system probe cws functionality. * fix incorrect merge 76199c4
…robe
Title says it all.
Add a bunch of statistics for internal profiling of performance of the system probe cws functionality.
Describe how to test/QA your changes
Code is not customer facing; it is used to help qa.