Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCII-1605] Update Go version to 1.21.10 #25477

Merged
merged 3 commits into from May 13, 2024
Merged

Conversation

jeremy-hanna
Copy link
Contributor

@jeremy-hanna jeremy-hanna commented May 8, 2024

What does this PR do?

Workflow created PR to update build images to use DataDog/datadog-agent-buildimages#584 and builds the agent with 1.21.10

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@jeremy-hanna jeremy-hanna requested review from a team as code owners May 8, 2024 21:33
@jeremy-hanna jeremy-hanna added team/agent-shared-components qa/no-code-change Skip QA week as there is no code change in Agent code labels May 8, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 10, 2024

Regression Detector

Regression Detector Results

Run ID: e26d30b2-930d-4ae6-b3f5-5356b524e8ac
Baseline: 1f10c8a
Comparison: c031fe8

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -4.77 [-9.72, +0.17]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
basic_py_check % cpu utilization +1.39 [-1.22, +3.99]
pycheck_1000_100byte_tags % cpu utilization +0.84 [-3.73, +5.41]
uds_dogstatsd_to_api_cpu % cpu utilization +0.79 [-2.09, +3.67]
trace_agent_json ingress throughput +0.01 [-0.00, +0.02]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.06, +0.03]
idle memory utilization -0.09 [-0.12, -0.05]
otel_to_otel_logs ingress throughput -0.10 [-0.48, +0.28]
file_tree memory utilization -1.28 [-1.39, -1.17]
file_to_blackhole % cpu utilization -4.77 [-9.72, +0.17]
tcp_syslog_to_blackhole ingress throughput -17.27 [-36.65, +2.12]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Member

@amenasria amenasria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@pgimalac
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 13, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 25m)

Use /merge -c to cancel this operation!

@jeremy-hanna jeremy-hanna changed the title Update Go version to 1.21.10 [ASCII-1605] Update Go version to 1.21.10 May 13, 2024
@dd-mergequeue dd-mergequeue bot merged commit b10081b into main May 13, 2024
197 of 198 checks passed
@dd-mergequeue dd-mergequeue bot deleted the update-go-to-1.21.10 branch May 13, 2024 16:51
@github-actions github-actions bot added this to the 7.55.0 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants