Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_explicit in test_aggregates #473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix test_explicit in test_aggregates #473

wants to merge 1 commit into from

Conversation

KhaledTo
Copy link
Contributor

test_explicit was failing because amount_sum aggregate was missing from defaut cube.

@KhaledTo KhaledTo changed the title BUG: Fix test_explicit in test_aggregates Fix test_explicit in test_aggregates May 17, 2019
@KhaledTo
Copy link
Contributor Author

KhaledTo commented May 17, 2019 •
edited

We also need to remove raise NotImplementedError("Depreciated in this context")

cubes/tests/common.py

Line 54 in 140133e

raise NotImplementedError("Depreciated in this context")

But before that I need to understand why this exception is raised there. Can someone explain me that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@KhaledTo