Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change formatters doc example from "text_table" option #367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RacingTadpole
Copy link

This looks like a great framework, thanks! I am spending some time getting my head around how it works, and thought I'd start by submitting a PR for a documentation change :-)

I noticed the example at http://cubes.readthedocs.io/en/v1.1/formatters.html doesn't work, because it references the "text_table" formatter, which is no longer available by default.

This PR needs a tiny change to merge - the old line

print formatter.format(result, "date") 

needs to be replaced, but I'm not sure what with yet.

Btw, I notice the slicer server accepts a format=json|csv parameter; I was looking at https://github.com/DataBrewery/cubes/blob/release-1.1/cubes/ext.py#L50-L52 because I guessed the allowed formats would match those (but they don't)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant